HI Since this impact TDX and SEV, would you please let me know what kind of test you have done? Have you validated TDX and SEV before you submit the patch? Please describe that clearly in your patch description.
Also please include AMD SEV reviewer in this patch series. Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of duntan > Sent: Friday, October 27, 2023 1:43 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic > and > remove BaseIoLibIntrinsicSev > > The goal is to have single BaseIoLibIntrinsic instance that can also used for > sev > and Tdx. > In this patch set, string I/O instructions are deleted in IoRead/WriteFifo > API. > Then change the source file of BaseIoLibIntrinsic to also support Tdx and sev > feature. So BaseIoLibIntrinsicSev and related assembly code can be removed. > > Dun Tan (7): > MdePkg: Create TdxLibNull.inf instance > MdePkg: Add CcProbeLibNull and TdxLibNull implement > MdePkg: simplify IoRead/WriteFifo in IoLibFifo.c > MdePkg:support Tdx and sev in BaseIoLibIntrinsic > OvmfPkg: Add CcProbeLib in PlatformInitLib.inf > OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files > MdePkg:remove BaseIoLibIntrinsicSev related code > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 14 > ++++++++++---- > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 61 > ------------------ > ------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 > -------------------- > -------------------------------------------------------------------------------------------------- > ------------- > MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm | 293 > ------------------ > -------------------------------------------------------------------------------------------------- > -------------------------------------------------------------------------------------------------- > ------------------------------------------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 45 > +++++++++++++++++++++++++++++++++++++-------- > MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h | 166 > ------------------------ > -------------------------------------------------------------------------------------------------- > -------------------------------------------- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 > -------------------- > -------------------------------------------------------------------------------------------------- > -- > MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm | 282 > ------------------ > -------------------------------------------------------------------------------------------------- > -------------------------------------------------------------------------------------------------- > -------------------------------------------------------------------- > MdePkg/Library/TdxLib/TdxLibNull.inf | 21 > +++++++++++++++++++++ > MdePkg/MdeLibs.dsc.inc | 4 +++- > MdePkg/MdePkg.dsc | 2 +- > OvmfPkg/AmdSev/AmdSevX64.dsc | 2 +- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +- > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 3 ++- > OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/OvmfXen.dsc | 2 +- > 21 files changed, 83 insertions(+), 1077 deletions(-) > delete mode 100644 > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifoSev.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibSev.h > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm > delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifoSev.nasm > create mode 100644 MdePkg/Library/TdxLib/TdxLibNull.inf > > -- > 2.31.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110190): https://edk2.groups.io/g/devel/message/110190 Mute This Topic: https://groups.io/mt/102215661/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
