Hi Laszlo, I searched for my name to find the patch, and did not find a numbered tag associated with the patch title, and overlook the comment. I'm sorry for the ignoring and inconvenience this have caused. Could you please help with reverting the patch? I will submit Version 2.
Yuanhao -----Original Message----- From: Laszlo Ersek <ler...@redhat.com> Sent: Wednesday, October 25, 2023 4:00 PM To: devel@edk2.groups.io; Xie, Yuanhao <yuanhao....@intel.com> Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L <nathaniel.l.desim...@intel.com>; Isaac Oram <isaac.w.o...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> Subject: Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB Yuanhao, On 10/19/23 05:20, Yuanhao Xie wrote: > With the fact that CSM is not supported, the request is to remove the > cache setting for memory under 1MB. > This can be treated as the missing part of legacy CSM deprecation. > > This patch only set the 00000 to 9FFFF and C0000 to FFFFF as Write Back. > A0000-BFFFF range is still uncacheable for VGA. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Isaac Oram <isaac.w.o...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Eric Dong <eric.d...@intel.com> > Signed-off-by: Yuanhao Xie <yuanhao....@intel.com> > --- > > Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib. > c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi > b.c > b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi > b.c > index 05728275a5..38a8db6b3f 100644 > --- > a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLi > b.c > +++ b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMt > +++ rrLib.c > @@ -245,7 +245,7 @@ SetCacheMtrrAfterEndOfPei ( > &MtrrSetting, > 0xC0000, > 0x40000, > - CacheWriteProtected > + CacheWriteBack > ); > ASSERT_EFI_ERROR ( Status); > I find that this patch has been pushed as commit 474b81190261. Previously, I commented that the subject line of the patch was incorrect, because it didn't name MinPlatformPkg: https://edk2.groups.io/g/devel/message/109747 What was your reason for ignoring my comment? Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110024): https://edk2.groups.io/g/devel/message/110024 Mute This Topic: https://groups.io/mt/102037244/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
