REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4568
Coverity report 2 issues in OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c. In the function InstallCloudHvTablesTdx, the pointer is already checked. if (DsdtTable == NULL) { DEBUG ((DEBUG_INFO, "%a: no DSDT found\n", __func__)); ASSERT (FALSE); } But this comes into play only in DEBUG mode, in Release mode, that would be an error with dereferencing null pointer. Fix this by adding CpuDeadLoop() after assert. In addition, the status of "AcpiProtocol->InstallAcpiTable" is overwritten before it can be used in the function, it is better to check it before overwriting. code: https://github.com/sunceping/edk2/tree/fixcoverityerrors.v1 Cc: Gerd Hoffmann <kra...@redhat.com> Cc: Jiewen Yao <jiewen....@intel.com> Cc: Min Xu <min.m...@intel.com> Signed-off-by: Ceping Sun <cepingx....@intel.com> Ceping Sun (2): OvmfPkg/AcpiPlatformDxe: Avoid possible NULL pointer dereference OvmfPkg/AcpiPlatformDxe: Check the status to ensure no error OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109791): https://edk2.groups.io/g/devel/message/109791 Mute This Topic: https://groups.io/mt/102055422/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-