On Wed, 18 Oct 2023 at 15:43, Laszlo Ersek <ler...@redhat.com> wrote: > > On 10/12/23 11:10, Laszlo Ersek wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > > > > The RealTimeClockLib class header in edk2's EmbeddedPkg mistakenly > > declares a function called LibRtcVirtualNotifyEvent(). No component ever > > calls this function across module boundaries; all RealTimeClockLib > > instances in edk2 and edk2-platforms are supposed to register -- and do > > register -- their SetVirtualAddressMap() notification functions. > > > > After the edk2-platforms and edk2-non-osi changes, we can repeat the > > procedure form the edk2-platforms series in edk2. In those > > RealTimeClockLib instances that define LibRtcVirtualNotifyEvent(), > > demonstrate that either (a) the usage is module-internal, or (b) there > > is no usage. In case (a), rename LibRtcVirtualNotifyEvent() to > > VirtualNotifyEvent(), and make it static. In case (b), remove the > > function definition. > > > > There is a superficial name match in > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe. Note that that module is a > > *driver*, not a library instance; what's more, > > PcatRealTimeClockRuntimeDxe does not depend on "EmbeddedPkg.dec" at all. > > Treat that module too as case (a), right at the front of the series. > > > > Finally, drop the LibRtcVirtualNotifyEvent() API declaration. > > > > Cc: Abner Chang <abner.ch...@amd.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Daniel Schaefer <g...@danielschaefer.me> > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > Cc: Ray Ni <ray...@intel.com> > > Can I get an ACK for the last three (EmbeddedPkg) patches? >
For the series, Reviewed-by: Ard Biesheuvel <a...@kernel.org> > > > > Laszlo Ersek (5): > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: rename > > LibRtcVirtualNotifyEvent > > ArmPlatformPkg/PL031RealTimeClockLib: hide LibRtcVirtualNotifyEvent > > EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/VirtualRealTimeClockLib: drop LibRtcVirtualNotifyEvent > > EmbeddedPkg/RealTimeClockLib: drop LibRtcVirtualNotifyEvent from lib > > class > > > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 5 > > ++-- > > EmbeddedPkg/Include/Library/RealTimeClockLib.h | 15 > > ------------ > > EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c | 24 > > -------------------- > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 18 > > --------------- > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 > > ++-- > > 5 files changed, 6 insertions(+), 61 deletions(-) > > > > > > base-commit: 95c9f470ca6eab23bfd016bd438f932d7263d395 > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109752): https://edk2.groups.io/g/devel/message/109752 Mute This Topic: https://groups.io/mt/101914677/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
