Back in the mists of time (January 2020) I submitted a set to clean up
and fix a few bugs in ARM/AArch64 BaseLib SetJump/LongJump implementations:
https://edk2.groups.io/g/devel/message/65812
Then hubris struck and I meant to refactor the code for all architectures,
and since this was in my first week in a new job, that meant everything
got completely dropped on the floor.
Then Andrei's fix of similar issues for RiscV64 made me remember this set.
And I figured, let's dial back the ambition and get the actual fixes
merged.
The overall scope remains:
- Fix comments (drop Itanium mention, correct spelling)
- Make code match existing comments
- Don't try to optimise ARM for executing on the 8088
- Use the correct register sizes on AArch64
- Actually follow the API on ARM
And like the original submission, the changes to .asm files have been
neither build nor runtime tested.
Any acks/reviewed-bys have been dropped, it having been over 3.5 years.
Changes since v1:
- Rebased to current edk2 main.
- Incorporate Ard's feedback on maintaining a clean call stack for
InternalAssertJumpBuffer, *and* conditionalising it on !MDEPKG_NDEBUG.
- Changed authorship to my current identity (the company I worked at
during v1 having been acquired by my current employer, this feels
like a reasonable course of action).
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Sami Mujawar <sami.muja...@arm.com>
Cc: Andrei Warkentin <andrei.warken...@intel.com>
Leif Lindholm (5):
MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations
MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations
MdePkg/BaseLib: use normal register init in ARM SetJump
implementations
MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump
MdePkg/BaseLib: ensure ARM LongJump never returns 0
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 19 +++++++++++++------
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 19 +++++++++++++------
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 7 ++++---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 7 ++++---
4 files changed, 34 insertions(+), 18 deletions(-)
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109074): https://edk2.groups.io/g/devel/message/109074
Mute This Topic: https://groups.io/mt/101600799/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
