Pushed via: PR - https://github.com/tianocore/edk2/pull/4841 Commit - https://github.com/tianocore/edk2/commit/4fb69c2bee3006b08ca2abba58843f7573e0c5c6
Best Regards, Hao Wu > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, August 10, 2023 10:39 AM > To: Ranbir Singh <rsi...@ventanamicro.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com> > Subject: RE: [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix > SIGN_EXTENSION Coverity issue > > Reviewed-by: Hao A Wu <hao.a...@intel.com> > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: Ranbir Singh <rsi...@ventanamicro.com> > > Sent: Monday, July 17, 2023 7:59 PM > > To: devel@edk2.groups.io; rsi...@ventanamicro.com > > Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ray <ray...@intel.com> > > Subject: [PATCH v2 1/1] MdeModulePkg/Bus/Ata/AtaBusDxe: Fix > > SIGN_EXTENSION Coverity issue > > > > From: Ranbir Singh <ranbir.sin...@dell.com> > > > > Line number 365 does contain a typecast with UINT32, but it is after > > all the operations (16-bit left shift followed by OR'ing) are over. > > To avoid any SIGN_EXTENSION, typecast the intermediate result after > > 16-bit left shift operation immediately with UINT32. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4209 > > > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com> > > Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com> > > --- > > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c > > b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c > > index a77852bae054..57aefa04c215 100644 > > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c > > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaPassThruExecute.c > > @@ -362,7 +362,7 @@ IdentifyAtaDevice ( > > // Check logical block size // if ((PhyLogicSectorSupport & > > BIT12) != 0) > {- > > BlockMedia->BlockSize = (UINT32)(((IdentifyData->logic_sector_size_hi > > BlockMedia-><< 16) > > | IdentifyData->logic_sector_size_lo) * sizeof (UINT16));+ BlockMedia- > > >BlockSize = (UINT32)(((UINT32)(IdentifyData->logic_sector_size_hi << > > >16) | > > IdentifyData->logic_sector_size_lo) * sizeof (UINT16)); } > > AtaDevice- > > >BlockIo.Revision = EFI_BLOCK_IO_PROTOCOL_REVISION2;-- > > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108897): https://edk2.groups.io/g/devel/message/108897 Mute This Topic: https://groups.io/mt/100212118/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
