Hi Michael, Apologies, I initially misunderstood what this patch was trying to do. As I understand this is an exception for one of the special cases to be handled differently by the plugin.
Acked-by: Sami Mujawar <[email protected]> Regards, Sami Mujawar On 14/09/2023, 09:42, "[email protected] <mailto:[email protected]> on behalf of Sami Mujawar via groups.io" <[email protected] <mailto:[email protected]> on behalf of [email protected] <mailto:[email protected]>> wrote: Hi Michael, I would prefer to have the debug macro checks enabled in DynamicTablesPkg to catch any issues. Please do not disable this feature for this package. Regards, Sami Mujawar On 13/09/2023, 18:08, "[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>" <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> wrote: From: Michael Kubacki <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> Adds a CI YAML entry to acknowledge a case where custom strings contain print specifiers for a single debug macro. Cc: Sami Mujawar <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> Cc: Alexei Fedorov <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> Cc: Pierre Gondois <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> Signed-off-by: Michael Kubacki <[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>> --- DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml index 5addf8626841..1d41d44bbf33 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml @@ -130,5 +130,13 @@ # should be ignore "AdditionalIncludePaths": [] # Additional paths to spell check # (wildcards supported) + }, + + "DebugMacroCheck": { + "StringSubstitutions": { + # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c + # Reason: Debug format strings are dynamically set. + "Parser[Index].Format": "%d" + } } } -- 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108645): https://edk2.groups.io/g/devel/message/108645 Mute This Topic: https://groups.io/mt/101341656/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
