On Thu, Sep 14, 2023 at 09:23:12AM +0200, Andrew Jones wrote: > On Wed, Sep 13, 2023 at 12:55:49PM +0200, Laszlo Ersek wrote: > > Riscv64 KVM services SBI calls internally, so OpenSBI is not used in such > > setups. Restrict the "-bios" flag accordingly. Thanks: Andrei, Drew. > > > > Cc: Andrei Warkentin <andrei.warken...@intel.com> > > Cc: Andrew Jones <ajo...@ventanamicro.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Sunil V L <suni...@ventanamicro.com> > > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > --- > > OvmfPkg/RiscVVirt/README.md | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/OvmfPkg/RiscVVirt/README.md b/OvmfPkg/RiscVVirt/README.md > > index dbb40bbe89b0..193e4afe8dee 100644 > > --- a/OvmfPkg/RiscVVirt/README.md > > +++ b/OvmfPkg/RiscVVirt/README.md > > @@ -86,3 +86,8 @@ then specify that binary for QEMU, with the following > > additional command line > > option: > > > > -bios $OPENSBI_DIR/build/platform/generic/firmware/fw_dynamic.bin > > + > > +Note that the above only makes a difference with software emulation (which > > you > > +can force with `-M accel=tcg`). With hardware virtualization (`-M > > accel=kvm`), > > +KVM services the SBI (Supervisor Binary Interface) calls internally, > > therefore > > +any externally loaded OpenSBI binary is ignored. > > > > > Reviewed-by: Andrew Jones <ajo...@ventanamicro.com>
Eh, sorry for the redundant r-b and my 'ignored' comment still stands, i.e. I wouldn't mind seeing a v2 with s/ignored/rejected/ Thanks, drew -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108640): https://edk2.groups.io/g/devel/message/108640 Mute This Topic: https://groups.io/mt/101334264/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
