On Wed, 16 Aug 2023 at 10:56, Nhi Pham <n...@amperemail.onmicrosoft.com> wrote: > > Hi Ard and Ming, > > I have been seeing an issue with StandaloneMM HobLib that can be fixed > by this patch as well. > > The function CreateHob() in the HobLib instance > StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > does not work at all. The HobList is early created by the > StandaloneMmCoreEntryPoint then it is relocated on the heap memory by > StandaloneMmCore. But the FreeMemoryTop and FreeMemoryBottom are not > updated accordingly and the HOB free memory top is overlapped with the > heap space. This causes the CreateHob() function to not work as > expected. Introducing the PcdMemoryHobSize is reasonable to fix this issue. > > I tested this patch in my end. > > Tested-by: Nhi Pham <n...@os.amperecomputing.com> >
Thanks for reminding me. So if the HOB creation is completely broken, are we sure this is the correct fix? Wouldn't it be better to update FreeMemoryTop and FreeMemoryBottom to the correct values? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108145): https://edk2.groups.io/g/devel/message/108145 Mute This Topic: https://groups.io/mt/89020085/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
