On 8/3/23 23:25, Ard Biesheuvel wrote: > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > <michael.d.kin...@intel.com> wrote: >> >> Hi Ard, >> >> This is the email with the analysis and the flag >> setting required for SMP to work with SMM enabled for >> IA32/X64 QEMU. >> >> https://edk2.groups.io/g/devel/message/102364 >> >> >> I tried latest version of QEMU earlier in the Summer >> and did not see any improvements. >> > > Ah thanks, I had forgotten all about that rabbit hole you went down :-)
Sorry Mike, I had also forgotten about that problem. > > So let's respin this with -smp 4 --accel=tcg,thread=single. It is > still an improvement to exercise the MP code even if it doesn't > strictly execute concurrently. (It will be very hard to > catch/reproduce true concurrency issues in TCG anyway) I think that's a good workaround. Thanks Laszlo > > Oliver, mind spinning a v2? > > Thanks, > > > >>> -----Original Message----- >>> From: Ard Biesheuvel <a...@kernel.org> >>> Sent: Thursday, August 3, 2023 9:54 AM >>> To: devel@edk2.groups.io; mikub...@linux.microsoft.com >>> Cc: ostef...@redhat.com; Feng, Bob C <bob.c.f...@intel.com>; Gerd >>> Hoffmann <kra...@redhat.com>; Yao, Jiewen <jiewen....@intel.com>; >>> Justen, Jordan L <jordan.l.jus...@intel.com>; Gao, Liming >>> <gaolim...@byosoft.com.cn>; Kinney, Michael D >>> <michael.d.kin...@intel.com>; Rebecca Cran <rebe...@bsdio.com>; Sean >>> Brogan <sean.bro...@microsoft.com>; Chen, Christine >>> <yuwei.c...@intel.com>; Laszlo Ersek <ler...@redhat.com> >>> Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP >>> in tests >>> >>> On Thu, 3 Aug 2023 at 16:37, Michael Kubacki >>> <mikub...@linux.microsoft.com> wrote: >>>> >>>> For the series. >>>> >>>> Reviewed-by: Michael Kubacki <michael.kuba...@microsoft.com> >>>> >>> >>> Thanks >>> >>> I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG >>> keeps timing out for me >>> >>> https://github.com/tianocore/edk2/pull/4718 >>> >>> Might it help if we restrict SMP to a subset of the builds? And would >>> it help if we added "--accel=tcg,thread=multi" ? >>> >>> >>> >>>> On 8/3/2023 7:44 AM, Oliver Steffen wrote: >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 >>>>> PR: https://github.com/tianocore/edk2/pull/4711 >>>>> >>>>> This series switches the OVMF CI jobs on Windows to a recent Qemu >>>>> version and re-enables SMP in the Qemu "Run to shell" CI jobs. >>>>> The Qemu tests run a little bit slower in SMP mode and sometimes >>>>> hit the time limit of 2 minutes, thus this limit is increased to 4 >>>>> minutes. >>>>> >>>>> Together with 81cb0371f9db ("CI: Use latest image for Linux jobs >>> (Qemu >>>>> 8, gcc 12)" this series is sufficient to close Bug 4324. >>>>> >>>>> >>>>> Gerd Hoffmann (1): >>>>> OvmfPkg/PlatformCI: Boot OVMF in SMP mode. >>>>> >>>>> Oliver Steffen (3): >>>>> OvmfPkg/PlatformCI: Use recent Qemu on Windows >>>>> OvmfPkg/PlatformCI VS2019: Disable workaround for cpuhp bugfix >>>>> CI: Increase time limit of "Run to shell" task to 4 minutes >>>>> >>>>> .../templates/platform-build-run-steps.yml | 2 +- >>>>> .../PlatformCI/.azurepipelines/Windows-VS2019.yml | 4 ++-- >>>>> OvmfPkg/PlatformCI/PlatformBuildLib.py | 13 +-------- >>> ---- >>>>> 3 files changed, 4 insertions(+), 15 deletions(-) >>>>> >>>> >>>> >>>> >>>> >>>> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107615): https://edk2.groups.io/g/devel/message/107615 Mute This Topic: https://groups.io/mt/100524063/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
