Hi OvmfPkg maintainer & reviewer, Please help review this patch.
Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Zhiguang Liu > Sent: Monday, July 10, 2023 11:17 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang <zhiguang....@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com>; Justen, > Jordan L <jordan.l.jus...@intel.com>; Gerd Hoffmann > <kra...@redhat.com>; Anthony Perard <anthony.per...@citrix.com>; Julien > Grall <jul...@xen.org> > Subject: [edk2-devel] [PATCH 3/4] OvmfPkg: Remove > applicationProcessorEntryPoint > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4494 > > Current reset vector uses 0xffffffe0 as AP waking vector, and expects GenFv > generates code aligned on a 4k boundary which will jump to this location. > However, some issues are listed below 1. GenFV doesn't generate code as > the comment expects, because GenFv assumes no modifications are > required to the VTF-0 'Volume Top File'. > 2. Even if removing VFT0 signature and let GenFv to modify, Genfv is hard- > code using another flash address 0xffffffd0. > 3. In the same patch series, AP waking vector code is removed from GenFv, > because no such usage anymore. The existing of first two issues also approve > the usage is not available for a long time. > > Therefore, remove AP waking vector related code. > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Julien Grall <jul...@xen.org> > Signed-off-by: Zhiguang Liu <zhiguang....@intel.com> > --- > OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm | 15 +++------------ > OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm | 16 +++------------- > 2 files changed, 6 insertions(+), 25 deletions(-) > > diff --git a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > index 12f2cedd67..8f94da89f7 100644 > --- a/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > +++ b/OvmfPkg/ResetVector/Ia16/ResetVectorVtf0.asm > @@ -160,22 +160,13 @@ guidedStructureEnd: > > ALIGN 16 > > -applicationProcessorEntryPoint: > ; > -; Application Processors entry point > +; 0xffffffe0 > ; > -; GenFv generates code aligned on a 4k boundary which will jump to this -; > location. (0xffffffe0) This allows the Local APIC Startup IPI to be -; used > to > wake up the application processors. > -; > - jmp EarlyApInitReal16 > - > -ALIGN 8 > - > - DD 0 > + DD 0, 0, 0 > > ; > -; The VTF signature > +; The VTF signature (0xffffffec) > ; > ; VTF-0 means that the VTF (Volume Top File) code does not require ; any > fixups. > diff --git a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > index 56749bdbc9..67156d8252 100644 > --- a/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > +++ b/OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm > @@ -39,23 +39,13 @@ xenPVHEntryPoint: > > BITS 16 > ALIGN 16 > - > -applicationProcessorEntryPoint: > -; > -; Application Processors entry point > ; > -; GenFv generates code aligned on a 4k boundary which will jump to this -; > location. (0xffffffe0) This allows the Local APIC Startup IPI to be -; used > to > wake up the application processors. > +; 0xffffffe0 > ; > - jmp EarlyApInitReal16 > - > -ALIGN 8 > - > - DD 0 > + DD 0, 0, 0 > > ; > -; The VTF signature > +; The VTF signature (0xffffffec) > ; > ; VTF-0 means that the VTF (Volume Top File) code does not require ; any > fixups. > -- > 2.31.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107155): https://edk2.groups.io/g/devel/message/107155 Mute This Topic: https://groups.io/mt/100322593/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
