> > To please both sides, how about: > 1. Remove the 'Status' assignment of the return value from > SetDriveParameters() > Based on my findings (https://edk2.groups.io/g/devel/message/106844), the > successful execution of SetDriveParameters() is not mandatory for > initializing > IDE mode hard disk device. >
Interestingly, my very first patch for this began with this approach only. > 2. Add DEBUG_WARN level debug message within SetDriveParameters() function > In function SetDriveParameters, for the 2 calls of AtaNonDataCommandIn (one > for the INITIALIZE DEVICE PARAMETERS command and the other for SET MULTIPLE > MODE command), if the return status is not EFI_SUCCESS, add debug message > to > display the information. > These can be added if desired so. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106935): https://edk2.groups.io/g/devel/message/106935 Mute This Topic: https://groups.io/mt/100124817/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
