- Fix "variable set but not used" error.
- Fix missing "EFIAPI" error.
- Fix typos.
Signed-off-by: Nickle Wang <nick...@nvidia.com>
Cc: Abner Chang <abner.ch...@amd.com>
Cc: Igor Kulchytskyy <ig...@ami.com>
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 20 ++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
index c65e2f51..e7ac8779 100644
--- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
+++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
@@ -2,7 +2,7 @@
Redfish feature driver implementation - Bios
(C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP<BR>
- Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
+ Copyright (c) 2022-2023, NVIDIA CORPORATION. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -18,10 +18,10 @@ HandleResource (
IN EFI_STRING Uri
);
-EFI_HANDLE medfishResourceConfigProtocolHandle;
+EFI_HANDLE mRedfishResourceConfigProtocolHandle;
/**
- Provising redfish resource by given URI.
+ Provisioning redfish resource by given URI.
@param[in] This Pointer to EFI_HP_REDFISH_HII_PROTOCOL
instance.
@param[in] Uri Target URI to create resource.
@@ -33,6 +33,7 @@ EFI_HANDLE medfishResourceConfigProtocolHandle;
**/
EFI_STATUS
+EFIAPI
RedfishResourceProvisioningResource (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri,
@@ -94,6 +95,7 @@ RedfishResourceProvisioningResource (
**/
EFI_STATUS
+EFIAPI
RedfishResourceConsumeResource (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -233,19 +235,16 @@ RedfishResourceConsumeResource (
**/
EFI_STATUS
+EFIAPI
RedfishResourceGetInfo (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
OUT REDFISH_SCHEMA_INFO *Info
)
{
- REDFISH_RESOURCE_COMMON_PRIVATE *Private;
-
if ((This == NULL) || (Info == NULL)) {
return EFI_INVALID_PARAMETER;
}
- Private = REDFISH_RESOURCE_COMMON_PRIVATE_DATA_FROM_RESOURCE_PROTOCOL (This);
-
AsciiStrCpyS (Info->Schema, REDFISH_SCHEMA_STRING_SIZE, RESOURCE_SCHEMA);
AsciiStrCpyS (Info->Major, REDFISH_SCHEMA_VERSION_SIZE,
RESOURCE_SCHEMA_MAJOR);
AsciiStrCpyS (Info->Minor, REDFISH_SCHEMA_VERSION_SIZE,
RESOURCE_SCHEMA_MINOR);
@@ -265,6 +264,7 @@ RedfishResourceGetInfo (
**/
EFI_STATUS
+EFIAPI
RedfishResourceUpdate (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -334,6 +334,7 @@ RedfishResourceUpdate (
**/
EFI_STATUS
+EFIAPI
RedfishResourceCheck (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -404,6 +405,7 @@ RedfishResourceCheck (
**/
EFI_STATUS
+EFIAPI
RedfishResourceIdentify (
IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This,
IN EFI_STRING Uri
@@ -478,7 +480,7 @@ EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL
mRedfishResourceConfig = {
handler.
@param[in] This Pointer to
EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance.
- @param[in] RedfishConfigServiceInfo Redfish service informaion.
+ @param[in] RedfishConfigServiceInfo Redfish service information.
@retval EFI_SUCCESS The handler has been initialized
successfully.
@retval EFI_DEVICE_ERROR Failed to create or configure the REST
EX protocol instance.
@@ -799,7 +801,7 @@ RedfishResourceEntryPoint (
return EFI_ALREADY_STARTED;
}
- medfishResourceConfigProtocolHandle = ImageHandle;
+ mRedfishResourceConfigProtocolHandle = ImageHandle;
mRedfishResourcePrivate = AllocateZeroPool (sizeof
(REDFISH_RESOURCE_COMMON_PRIVATE));
CopyMem (&mRedfishResourcePrivate->ConfigHandler, &mRedfishConfigHandler,
sizeof (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL));
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105794): https://edk2.groups.io/g/devel/message/105794
Mute This Topic: https://groups.io/mt/99362113/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
