Reviewed-by: Jiewen Yao <jiewen....@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun Qin > Sent: Friday, June 2, 2023 2:30 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; > Zhang, Qi1 <qi1.zh...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com> > Subject: [edk2-devel] [PATCH v1 3/3] SecurityPkg: SubClassTpm: Updated > default value > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 > > This change updated the default value of TPM device subclass PCD to > `0x010E0000` in order to match the definition of EFI_PERIPHERAL_TPM > from PI specification v1.8. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Qi Zhang <qi1.zh...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > Signed-off-by: Kun Qin <kuqi...@gmail.com> > --- > SecurityPkg/SecurityPkg.dec | 6 +++--- > SecurityPkg/SecurityPkg.uni | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec > index 0a8042d63fe1..53aa7ec43557 100644 > --- a/SecurityPkg/SecurityPkg.dec > +++ b/SecurityPkg/SecurityPkg.dec > @@ -308,10 +308,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] > gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass|0|UINT8|0x00000006 > > > > ## Progress Code for TPM device subclass definitions.<BR><BR> > > - # EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000D0000) = > 0x010D0000<BR> > > + # EFI_PERIPHERAL_TPM = (EFI_PERIPHERAL | 0x000E0000) = > 0x010E0000<BR> > > # @Prompt Status Code for TPM device definitions > > - # @ValidList 0x80000003 | 0x010D0000 > > - > gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010D000 > 0|UINT32|0x00000007 > > + # @ValidList 0x80000003 | 0x010E0000 > > + > gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010E0000 > |UINT32|0x00000007 > > > > ## Defines the IO port used to trigger a software System Management > Interrupt (SMI).<BR><BR> > > # Used as the SMI Command IO port by security functionality that triggers > a > software SMI such > > diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni > index 68587304d779..6c28b8021333 100644 > --- a/SecurityPkg/SecurityPkg.uni > +++ b/SecurityPkg/SecurityPkg.uni > @@ -169,7 +169,7 @@ > #string > STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_PROM > PT #language en-US "Status Code for TPM device definitions" > > > > #string > STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_HELP > #language en-US "Progress Code for TPM device subclass > definitions.<BR><BR>\n" > > - > "EFI_PERIPHERAL_TPM = > (EFI_PERIPHERAL | 0x000D0000) = 0x010D0000<BR>" > > + > "EFI_PERIPHERAL_TPM = > (EFI_PERIPHERAL | 0x000E0000) = 0x010E0000<BR>" > > > > #string > STR_gEfiSecurityPkgTokenSpaceGuid_PcdRsa2048Sha256PublicKeyBuffer_PRO > MPT #language en-US "One or more SHA 256 Hashes of RSA 2048 bit public keys > used to verify Recovery and Capsule Update images" > > > > -- > 2.40.1.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#105602): https://edk2.groups.io/g/devel/message/105602 > Mute This Topic: https://groups.io/mt/99271148/1772286 > Group Owner: devel+ow...@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen....@intel.com] > -=-=-=-=-=-= >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105605): https://edk2.groups.io/g/devel/message/105605 Mute This Topic: https://groups.io/mt/99271148/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-