On Thu, 11 May 2023 at 15:30, Anthony PERARD via groups.io <anthony.perard=citrix....@groups.io> wrote: > > On Thu, May 11, 2023 at 02:02:37PM +0200, Corvin Köhne wrote: > > diff --git a/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > > b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > > new file mode 100644 > > index 000000000000..ce52ad31cf25 > > --- /dev/null > > +++ b/OvmfPkg/Library/AcpiPlatformLib/DxeAcpiPlatformLib.c > > @@ -0,0 +1,62 @@ > > +/** @file > > + Copyright (c) 2023, Corvin Köhne <corv...@freebsd.org> > > As this new file move codes from OvmfPkg/XenAcpiPlatformDxe/Xen.c, > shouldn't you also copy the "Copyright" lines from that file as well? > > > Beside that, patch looks fine: > Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> >
Agreed Doing a bit of amateur archaeology, I think we should retain these as well Copyright (c) 2012, Bei Guan <gbtj...@gmail.com> Copyright (C) 2021, Red Hat, Inc. Also, please run this series through the CI (just send a PR to the tiancore/edk2 github project - it will not get merged but it will tell you if the CI spots any issues in the code) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105568): https://edk2.groups.io/g/devel/message/105568 Mute This Topic: https://groups.io/mt/98825804/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
