@Rebecca Cran I update v2 patch on the PR https://github.com/tianocore/edk2/pull/4431
Could you help to check about whether meet your expectation ? Thanks, Gua -----Original Message----- From: Rebecca Cran <rebe...@bsdio.com> Sent: Saturday, May 27, 2023 12:30 AM To: Guo, Gua <gua....@intel.com>; devel@edk2.groups.io Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com> Subject: Re: [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME On 5/25/23 6:09 PM, gua....@intel.com wrote: > > -%PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py > %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL -if %ERRORLEVEL% EQU > 1 ( > - echo. > - echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer > is required. > - echo. > - goto end > + %PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py > + %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL if %ERRORLEVEL% EQU 1 ( > + echo. > + echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer > is required. > + echo. > + goto end > + ) > ) If PYTHON_COMMAND is already defined we do still want to check it's a version we can use. So I don't think this part of the change is correct. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105336): https://edk2.groups.io/g/devel/message/105336 Mute This Topic: https://groups.io/mt/99141348/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
