Merged Mike
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca > Cran > Sent: Wednesday, May 10, 2023 7:50 AM > To: Ard Biesheuvel <a...@kernel.org> > Cc: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>; Feng, > Bob C <bob.c.f...@intel.com>; Chen, Christine <yuwei.c...@intel.com>; > Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn> > Subject: Re: [edk2-devel] [edk2-stable202305 PATCH 1/1] BaseTools: Revert > Set the CLANGDWARF OBJCOPY path in tools_def.template > > Mike/Liming: > > > GitHub PR with R-B added: https://github.com/tianocore/edk2/pull/4384 > > > -- > Rebecca Cran > > > On 5/10/23 07:51, Ard Biesheuvel wrote: > > On Wed, 10 May 2023 at 14:46, Rebecca Cran <rebe...@bsdio.com> wrote: > >> On 5/10/23 06:37, Ard Biesheuvel wrote: > >>> On Wed, 10 May 2023 at 14:31, Rebecca Cran <rebe...@bsdio.com> > wrote: > >>>> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00. > >>>> > >>>> While GCC uses objcopy for the OBJCOPY command, it's not needed for > the > >>>> CLANGDWARF toolchain and can be left as echo. > >>>> > >>> Are you sure you want to change this for IA32 and X86 as well? I'm not > >>> sure what the significance is, I suppose it sets the debuglink on the > >>> copies of the dll files? > >> Looking back to the tools_def.template from edk2-stable202302, we set > >> OBJCOPY_PATH for CLANG38 IA32 and X64, but not for CLANGPDB or > CLANGDWARF. > >> > >> I was thinking it's safer to keep existing behavior for now. > >> > > Existing behavior of CLANGDWARF for X86 and IA32, right? Yeah that makes > sense. > > > > Reviewed-by: Ard BIesheuvel <a...@kernel.org> > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104639): https://edk2.groups.io/g/devel/message/104639 Mute This Topic: https://groups.io/mt/98804529/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
