From: Gua Guo <gua....@intel.com> V4: Add Reviewed-by Info from Michael Kubacki Add more people into Cc List > BaseTools > F: BaseTools/ > M: Rebecca Cran <rebe...@bsdio.com> [bcran] > M: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > R: Bob Feng <bob.c.f...@intel.com> [BobCF] > R: Yuwei Chen <yuwei.c...@intel.com> [YuweiChen1110]
V3: Michael Kubacki Open1: I understand it was common in some parts of the code base at one point to wrap all expressions in parentheses, but can it be avoided in newly added code? And the parentheses are unnecessary in this case and don't follow typical Python style. Solution: Fixed, I will record it in my personal guideline to prevent happen again in next time that I change python code on Edk2. Open2: Due to the number of references, it would be easier to follow if this path were assigned to a variable: os.path.join(buildOutputBase, 'coverage.cov') Solution: Fixed, Use variable to reduce repetitive data. Open3: Solution: my local test, performance time increase 1.4% each build. I'm not sure whether the data is reasonable or not. But if won't fix it, I think one day unittest implement more and more on Edk2 part. It will break azurepipe line build in the future. V2/V1: Mike Kinney: Open1: Make commit message more clearly. Solution: Change commit message to use real case to describe the issue I encounter. Gua Guo (1): BaseTools/Plugin: Too many execute files cause "cmd too long" failure .../HostBasedUnitTestRunner.py | 46 +++++++++++++++++-- 1 file changed, 41 insertions(+), 5 deletions(-) -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104637): https://edk2.groups.io/g/devel/message/104637 Mute This Topic: https://groups.io/mt/98818782/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
