On 09/05/2023 09:43, Laszlo Ersek wrote:
I'm not subscribed to the list, so I don't have a copy of patch#1. I've
checked patch#1 at this URL:
https://listman.redhat.com/archives/edk2-devel-archive/2023-May/063591.html
and I'll comment on it using the cover letter:
I really like that patch, with one stylistic exception: in edk2,
explicit FALSE and TRUE comparisons are not desired. So I suggest:
ASSERT (!GetInterruptState ());
Twice.
In fact, I *think* that if you run uncrustify with the edk2 config on
the patch, then it will rewrite that code.
I built and ran uncrustify with the edk2 config but it did not modify
the code. (I did check that it would fix other deliberate errors such
as extra whitespace, so I don't think this was an error in my setup.)
I will send through v2 with the explicit "== FALSE" still present, for
consistency with the rest of the code in that file. (I think I vaguely
remember someone asking me to add the explicit comparisons when I first
submitted the code.) I'm happy for there to be a follow up patch to
change the coding style to remove all of the explicit boolean
comparisons, if that is what is wanted.
Thanks,
Michael
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104365): https://edk2.groups.io/g/devel/message/104365
Mute This Topic: https://groups.io/mt/98771393/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
