Hi, Nhi Pham Yao, Jiewen and Wang, Jian are the maintainers of SecurityPkg.
They can help to merge the patch if they have no concerns about the patch. > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nhi Pham > via groups.io > Sent: Thursday, April 27, 2023 1:38 PM > To: Xu, Min M <min.m...@intel.com>; devel@edk2.groups.io; > n...@os.amperecomputing.com; Yao, Jiewen <jiewen....@intel.com>; Wang, > Jian J <jian.j.w...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn> > Cc: patc...@amperecomputing.com > Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: > Add AUTH_SIG_NOT_FOUND Action > > Thanks Min. > > Could you help merge this patch to edk2? > > Regards, > > Nhi > > On 4/26/2023 2:54 PM, Xu, Min M wrote: > > It's good to me. > > Reviewed-by: Min Xu <min.m...@intel.com> > > > > Thanks > > > >> -----Original Message----- > >> From: Nhi Pham <n...@amperemail.onmicrosoft.com> > >> Sent: Thursday, April 20, 2023 11:49 AM > >> To: Xu, Min M <min.m...@intel.com>; devel@edk2.groups.io; > >> n...@os.amperecomputing.com; Yao, Jiewen <jiewen....@intel.com>; > Wang, > >> Jian J <jian.j.w...@intel.com> > >> Cc: patc...@amperecomputing.com > >> Subject: Re: [edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: > >> Add AUTH_SIG_NOT_FOUND Action > >> > >> Hi Min, > >> > >> This SEI test passes: > >> > >> SecureBoot - TestImage2.bin in Image Execution Info Table with > >> SIG_NOT_FOUND. -- PASS > >> 00C3C2F2-39D5-4D35-B7E7-587CA0F3CB75 > >> > SctPkg/TestCase/UEFI/EFI/RuntimeServices/SecureBoot/BlackBoxTest/Imag > >> eLoa > >> dingBBTest.c:1103:Status > >> - Success > >> > >> The test image binary is different to the one in the commit message > >> due to some bug fixes in the SEI test suite. The right test case to > >> catch this bug is 00C3C2F2- > >> 39D5-4D35-B7E7-587CA0F3CB75 > >> > >> You can check the test code at > >> https://github.com/ARM-software/bbr-acs/blob/main/bbsr/sct- > >> tests/SecureBoot/BlackBoxTest/ImageLoadingBBTest.c > >> > >> Thanks, > >> > >> Nhi > >> > >> On 4/19/2023 6:20 AM, Xu, Min M wrote: > >>> On Friday, April 14, 2023 1:18 PM, Nhi Pham wrote: > >>>> Hi, > >>>> > >>>> Ping for reviewing. > >>>> > >>>> Let me know if I need anything for this patch. > >>> Do you test the change and what's the test result? Can you provide > >>> the > >> validation result? > >>> Thanks > >>> Min > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103694): https://edk2.groups.io/g/devel/message/103694 Mute This Topic: https://groups.io/mt/98215665/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-