> On 21. Apr 2023, at 08:49, Gerd Hoffmann <kra...@redhat.com> wrote: > > On Fri, Apr 21, 2023 at 06:01:11AM +0000, Marvin Häuser wrote: >> >>>> On 21. Apr 2023, at 06:45, Gerd Hoffmann <kra...@redhat.com> wrote: >>> >>> Not needed any more on modern toolchains, they are better >>> in not creating a GOT without this trick. >> >> Hi Gerd, >> >> Thanks! Just out of interest, how did you test this and what were the >> results? > > Patch #1, adding a linker script assert as suggested by ard, then: > > * compile + test on my local workstation (fedora 37, gcc 12). > * run CI > * compile on some older distros: > - rhel-8 (gcc 8) > - ubuntu-18.04 (gcc 7)
Did you include NOOPT? GCC5 specifies USING_LTO for DEBUG and RELEASE, thus the visibility would not be changed anyway. If this works, I hope the series makes it in time for the next stable tag. :) Thanks! Best regards, Marvin > > take care, > Gerd > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103376): https://edk2.groups.io/g/devel/message/103376 Mute This Topic: https://groups.io/mt/98404595/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
