Reviewed-by: Nickle Wang <nick...@nvidia.com> Regards, Nickle
> -----Original Message----- > From: abner.ch...@amd.com <abner.ch...@amd.com> > Sent: Tuesday, April 18, 2023 3:16 PM > To: devel@edk2.groups.io > Cc: Isaac Oram <isaac.w.o...@intel.com>; Abdul Lateef Attar > <abdat...@amd.com>; Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy > <ig...@ami.com>; Tinh Nguyen <tinhngu...@os.amperecomputing.com> > Subject: [edk2-platforms][PATCH V2 12/14] ManageabilityPkg: Add > Manageability PCDs > > External email: Use caution opening links or attachments > > > From: Abner Chang <abner.ch...@amd.com> > > Add PCDs to control ManageabilityPkg > modules. > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > Cc: Isaac Oram <isaac.w.o...@intel.com> > Cc: Abdul Lateef Attar <abdat...@amd.com> > Cc: Nickle Wang <nick...@nvidia.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > Cc: Tinh Nguyen <tinhngu...@os.amperecomputing.com> > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 8 ++++++++ > .../Include/Dsc/Manageability.dsc | 16 +++++++++++++++- > Features/ManageabilityPkg/ManageabilityPkg.dsc | 10 ++++++++++ > 3 files changed, 33 insertions(+), 1 deletion(-) > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec > b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 6b198e6a3c..6f58ab4f45 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -68,3 +68,11 @@ > # @Prompt MCTP KCS (Memory mapped) I/O base address > > gManageabilityPkgTokenSpaceGuid.PcdMctpKcsBaseAddress|0xca2|UINT32|0x > 00000004 > > +[PcdsFeatureFlag] > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable|FALSE|BO > OLEAN|0x10000001 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable|FALSE|B > OOLEAN|0x10000002 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable|FALSE|BO > OLEAN|0x10000003 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|B > OOLEAN|0x10000004 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|B > OOLEAN|0x10000005 > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable|FALSE|BOOLEAN|0x10000006 > + > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > index 0fab562844..5e7cdb885f 100644 > --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > @@ -25,14 +25,28 @@ > > PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServi > cesTablePointerLib.inf > > [Components.IA32, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable == > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > +!endif > > [Components.X64, Components.AARCH64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable == > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > +!endif > > [Components.X64] > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable == > TRUE > ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > +!endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable == > TRUE > ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.inf > +!endif > + > +!if > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable == TRUE > > ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbiosTransferDxe.i > nf > - ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == > TRUE > + ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc > b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index 959b3eabd2..41a8957954 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -28,6 +28,16 @@ > gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable > |FALSE > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE > > + # > + # Manageability modules > + # > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilitySmmIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityPeiIpmiEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable > |TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable > |TRUE > + > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferE > nable|TRUE > + > # > # Include common libraries > # > -- > 2.37.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103288): https://edk2.groups.io/g/devel/message/103288 Mute This Topic: https://groups.io/mt/98339125/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
