Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
Regards,
Sami Mujawar
On 13/04/2023 02:14 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois <pierre.gond...@arm.com>
Booting a Juno-r0 with a DEBUG build triggers an ASSERT when
processing the library constructors of:
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
JunoPciHostBridgeLib.inf::HWPciRbInit() returns an error code
as Juno-r0 doesn't support PCIe.
Check Juno's revision in HWPciRbInit() before setting up the
PCIe root complex.
Reported-by: Fabien Ficheau <fabien.fich...@arm.com>
Signed-off-by: Pierre Gondois <pierre.gond...@arm.com>
---
.../ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
index 0755dc155616..583efd0efb16 100644
--- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
+++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
@@ -69,6 +69,13 @@ HWPciRbInit (
UINTN TranslationTable;
EFI_CPU_IO2_PROTOCOL *CpuIo;
EFI_STATUS Status;
+ UINT32 JunoRevision;
+
+ GetJunoRevision (JunoRevision);
+ DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision));
+ if (JunoRevision == JUNO_REVISION_R0) {
+ return EFI_SUCCESS;
+ }
PCI_TRACE ("VExpressPciRbInit()");
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102956): https://edk2.groups.io/g/devel/message/102956
Mute This Topic: https://groups.io/mt/98240078/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
