Yes, nice comment Thanks Zhiguang
> -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Wednesday, April 12, 2023 4:04 PM > To: Liu, Zhiguang <zhiguang....@intel.com>; devel@edk2.groups.io > Cc: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> > Subject: RE: [PATCH] SimicsOpenBoardPkg: Remove duplicated > SmmLockBox.inf > > Zhiguang, > Can you please remove it from > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc? > > Thanks, > Ray > > > -----Original Message----- > > From: Liu, Zhiguang <zhiguang....@intel.com> > > Sent: Wednesday, April 12, 2023 2:40 PM > > To: devel@edk2.groups.io > > Cc: Liu, Zhiguang <zhiguang....@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Ni, Ray <ray...@intel.com> > > Subject: [PATCH] SimicsOpenBoardPkg: Remove duplicated > SmmLockBox.inf > > > > Remove SmmLockBox.inf to fix a build issue, because it is already been > > included from MinPlatform dsc/fdf file > > > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Signed-off-by: Zhiguang Liu <zhiguang....@intel.com> > > --- > > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | > 1 > > - > > 1 file changed, 1 deletion(-) > > > > diff --git > > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > > index 1719513d3a..221706ae03 100644 > > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > > +++ > > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > > @@ -202,7 +202,6 @@ INF UefiCpuPkg/CpuDxe/CpuDxe.inf INF > > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf > > INF > > > MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutor > > Dxe.inf > > INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf > > -INF MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > > INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf > > INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > > -- > > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102872): https://edk2.groups.io/g/devel/message/102872 Mute This Topic: https://groups.io/mt/98214333/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
