[AMD Official Use Only - General]
> -----Original Message-----
> From: Tinh Nguyen <tinhngu...@amperemail.onmicrosoft.com>
> Sent: Tuesday, April 11, 2023 1:27 AM
> To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.o...@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <abdullateef.at...@amd.com>; Nickle Wang <nick...@nvidia.com>; Igor
> Kulchytskyy <ig...@ami.com>
> Subject: Re: [edk2-platforms][PATCH 13/14] ManageabilityPkg: Relocate
> Manageability.dsc
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> As someone mentioned before, you should move this library for arm/arm64
> to Manageability.dsc
Ah yes, I will.
>
> btw, the files that are included in dsc should have the extension dsc.inc.
I personally don’t like to have ".inc" for the included metafiles, that is
annoying when I do the search specifically to DSC files.
I don’t see having file extension ".inc" to the included metafiles is a rule
that mentioned in the edk2 specs. The example of included metafile in DCS we
can see in the edk2 DSC spec is also named without ".inc".
So I would rather just keep it as Manageability.dsc without ".inc' or name it
as Manageability.inc.dsc.
Thanks
Abner
>
> Regards,
>
> Tinh
>
> On 4/3/2023 10:04 PM, abner.ch...@amd.com wrote:
> > [EXTERNAL EMAIL NOTICE: This email originated from an external sender.
> > Please be mindful of safe email handling and proprietary information
> > protection practices.]
> >
> >
> > From: abnchang <abnch...@amd.com>
> >
> > Relocate Manageability.dsc to just under \Include folder.
> >
> > Signed-off-by: Abner Chang <abner.ch...@amd.com>
> > Cc: Isaac Oram <isaac.w.o...@intel.com>
> > Cc: Abdul Lateef Attar <abdat...@amd.com>
> > Cc: Nickle Wang <nick...@nvidia.com>
> > Cc: Igor Kulchytskyy <ig...@ami.com>
> > Cc: Tinh Nguyen <tinhngu...@amperemail.onmicrosoft.com>
> > ---
> > Features/ManageabilityPkg/Include/{Dsc => }/Manageability.dsc | 0
> > Features/ManageabilityPkg/ManageabilityPkg.dsc | 2 +-
> > 2 files changed, 1 insertion(+), 1 deletion(-)
> > rename Features/ManageabilityPkg/Include/{Dsc => }/Manageability.dsc
> > (100%)
> >
> > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > b/Features/ManageabilityPkg/Include/Manageability.dsc
> > similarity index 100%
> > rename from Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > rename to Features/ManageabilityPkg/Include/Manageability.dsc
> > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > index 41a8957954..a0712d1c0a 100644
> > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > @@ -53,4 +53,4 @@
> > [LibraryClasses]
> >
> > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTr
> > ansportNullLib/BaseManageabilityTransportNull.inf
> >
> > -!include Include/Dsc/Manageability.dsc
> > +!include Include/Manageability.dsc
> > --
> > 2.37.1.windows.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102798): https://edk2.groups.io/g/devel/message/102798
Mute This Topic: https://groups.io/mt/98037416/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
