Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran > Sent: Monday, April 3, 2023 5:33 PM > To: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>; Chen, > Christine <yuwei.c...@intel.com>; Kinney, Michael > D <michael.d.kin...@intel.com> > Cc: Rebecca Cran <rebe...@bsdio.com> > Subject: [edk2-devel] [PATCH edk2-basetools 1/1] DscBuildData.py: set > CC_FLAGS2 when running on Windows > > CC_FLAGS2 also needs to be set when running on Windows, otherwise the > wrong line is added and nmake fails when building using Visual Studio. > > Signed-off-by: Rebecca Cran <rebe...@bsdio.com> > --- > edk2basetools/Workspace/DscBuildData.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/edk2basetools/Workspace/DscBuildData.py > b/edk2basetools/Workspace/DscBuildData.py > index f6bf326018c6..8c402e189090 100644 > --- a/edk2basetools/Workspace/DscBuildData.py > +++ b/edk2basetools/Workspace/DscBuildData.py > @@ -2895,6 +2895,7 @@ def GenerateByteArrayValue (self, StructuredPcds): > CC_FLAGS2 = LinuxCFLAGS2 > if sys.platform == "win32": > CC_FLAGS = WindowsCFLAGS > + CC_FLAGS2 = WindowsCFLAGS > BuildOptions = OrderedDict() > for Options in self.BuildOptions: > if Options[2] != EDKII_NAME: > -- > 2.34.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102450): https://edk2.groups.io/g/devel/message/102450 Mute This Topic: https://groups.io/mt/98050197/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
