[AMD Official Use Only - General]
Hi Sean,
Renamed the AMD/MinBoardPkg to AMD/AmdMinBoardPkg and submitted the V4
version for review.
PR: https://github.com/tianocore/edk2-platforms/pull/75
Thanks
AbduL
-----Original Message-----
From: Sean Brogan <spbro...@outlook.com>
Sent: 01 April 2023 01:50
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef)
<abdullateef.at...@amd.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Leif Lindholm
<quic_llind...@quicinc.com>; Chang, Abner <abner.ch...@amd.com>; Michael D
Kinney <michael.d.kin...@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 1/3] Platform/AMD: Adds MinBoardPkg to
support MinPlatformPkg
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Regardless of directory path I would suggest that all "Packages" have a unique
and descriptive name. MinBoardPkg doesn't meet that
suggestion. If/when the edk2 CI tools run I would expect problems/odd
behavior if two packages collide in naming.
Thanks
Sean
On 3/22/2023 11:13 PM, Abdul Lateef Attar via groups.io wrote:
> Adds initial DEC and DSC file for MinBoardPkg.
> This package provides supporting modules for AMD boards to leverage
> MinPlatformPkg framework.
>
> Signed-off-by: Abdul Lateef Attar <abdat...@amd.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Leif Lindholm <quic_llind...@quicinc.com>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> ---
> Platform/AMD/MinBoardPkg/MinBoardPkg.dec | 19 +++++++++++++++++++
> Platform/AMD/MinBoardPkg/MinBoardPkg.dsc | 21 +++++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 Platform/AMD/MinBoardPkg/MinBoardPkg.dec
> create mode 100644 Platform/AMD/MinBoardPkg/MinBoardPkg.dsc
>
> diff --git a/Platform/AMD/MinBoardPkg/MinBoardPkg.dec
> b/Platform/AMD/MinBoardPkg/MinBoardPkg.dec
> new file mode 100644
> index 000000000000..23d737d196a2
> --- /dev/null
> +++ b/Platform/AMD/MinBoardPkg/MinBoardPkg.dec
> @@ -0,0 +1,19 @@
> +## @file MinBoardPkg.dec
> +# Declaration file for AMD's MinBoardPkg.
> +#
> +# This package supports AMD processor family based board as per the
> +MinPlatform # Arch specification.
> +#
> +# Copyright (c) 2023, Advanced Micro Devices, Inc. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent # # @par
> +Specification Reference:
> +#
> -https://tianocore-docs.github.io/edk2-MinimumPlatformSpecification/draft/ 0.7
> +##
> +
> +[Defines]
> + DEC_SPECIFICATION = 1.27
> + PACKAGE_NAME = MinBoardPkg
> + PACKAGE_GUID = 44F9D761-9ECB-43DD-A5AC-177E5048701B
> + PACKAGE_VERSION = 0.1
> +
> diff --git a/Platform/AMD/MinBoardPkg/MinBoardPkg.dsc
> b/Platform/AMD/MinBoardPkg/MinBoardPkg.dsc
> new file mode 100644
> index 000000000000..8c120c0649e7
> --- /dev/null
> +++ b/Platform/AMD/MinBoardPkg/MinBoardPkg.dsc
> @@ -0,0 +1,21 @@
> +## @file
> +# MinBoardPkg.dsc
> +#
> +# Description file for AMD MinBoardPkg # # Copyright (c) 2023,
> +Advanced Micro Devices, Inc. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent ##
> +
> +[Defines]
> + DSC_SPECIFICATION = 1.30
> + PLATFORM_GUID = 88F8A9AE-2FA0-4D58-A6F9-05F635C05F4E
> + PLATFORM_NAME = MinBoardPkg
> + PLATFORM_VERSION = 0.1
> + OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME)
> + BUILD_TARGETS = DEBUG | RELEASE | NOOPT
> + SUPPORTED_ARCHITECTURES = IA32 | X64
> +
> +[Packages]
> + MinBoardPkg/MinBoardPkg.dec
> +
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102413): https://edk2.groups.io/g/devel/message/102413
Mute This Topic: https://groups.io/mt/97795723/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
