Hi Ard,

I am occassionally seeing the following error when trying to run the Kvmtool guest firmware.

             add-symbol-file w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\PcRtc.dll 0xBBF80000              Loading driver at 0x000BBF70000 EntryPoint=0x000BBF82958 PcRtc.efi
             Failed to set memory attributes. Status = 00000002
            Failed to map memory for motorola,mc146818. Status = 00000002

            ASSERT_EFI_ERROR (Status = 00000002)
            ASSERT [PcRtc] w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\AutoGen.c(494): !(((INTN)(RETURN_STATUS)(Status)) < 0)

I am not sure why this issue only surfaces sometimes (which is worrying). However, the fix for this is patch 4/4 in this series.

Is it possible to review the ArmVirtPkg changes and if I have your approval to merge this series, please?

Regards,

Sami Mujawar

On 20/03/2023 02:05 pm, Sami Mujawar wrote:
This patch series has the following fixes for DynamicTablesPkg and
ArmVirtPkg/Kvmtool:

   1. Reduces the log output from TableHelperLib in DynamicTablesPkg.
   2. Fixes issue with parsing of the serial port node in
      ArmSerialPortParser in DynamicTablesPkg and
      EarlyFdt16550SerialPortHookLib in ArmVirtPkg. This issue
      was not observed until another entry was added in the 'chosen'
      node in the DT when doing some experiments.
   3. Fixes the DEPEX in the Kvmtool guest RTC library as the missing
      dependency on CPU Architecture protocol would cause occasional
      failures.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2596_bug_fix_dynamictables_kvmtool_v1

Sami Mujawar (4):
   DynamicTablesPkg: Reduce log output from TableHelperLib
   DynamicTablesPkg: Fix parsing of serial port node
   ArmVirtPkg: Fix parsing of serial port node
   ArmVirtPkg: Fix depex in kvmtool guest Rtc library

  ArmVirtPkg/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c 
    |  4 +--
  ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/KvmtoolRtcFdtClientLib.inf          
    |  4 +--
  
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
 | 28 ++++++++++----------
  DynamicTablesPkg/Library/FdtHwInfoParserLib/Serial/ArmSerialPortParser.c      
    |  4 +--
  4 files changed, 20 insertions(+), 20 deletions(-)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102114): https://edk2.groups.io/g/devel/message/102114
Mute This Topic: https://groups.io/mt/97731606/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to