Fix for the recovery logic which causes hdd unlock to fail if user supplies incorrect password. Every failed packet used to be recovered which is causing the incorrect password to be tried multiple times. This patch series fixes the logic to only retry commands that failed due to CRC error.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 Github pull: https://github.com/tianocore/edk2/pull/4157 Tests: - tested basic linux boot from AHCI on qemu - tested basic linux boot from AHCI on custom qemu which will fail 50% of the DMA commands with CRC error. Observed that all of the packets that failed were successfully retried. Custom Qemu: https://github.com/matalbec/qemu/tree/sata_dma_50p_fail - additionally Hunter Chang tested and confirmed that the password issue is no longer observed. Changes in V2: - Fixed code formatting issues Cc: Hao A Wu <hao.a...@intel.com> Cc: Ray Ni <ray...@intel.com> Cc: Hunter Chang <hunter.ch...@intel.com> Cc: Baraneedharan Anbazhagan <anbazha...@hp.com> Mateusz Albecki (1): MdeModulePkg/Ahci: Skip retry for non-transient errors .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 71 +++++++++++++++++-- .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 3 +- 2 files changed, 69 insertions(+), 5 deletions(-) -- 2.39.1.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101979): https://edk2.groups.io/g/devel/message/101979 Mute This Topic: https://groups.io/mt/97892836/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
