I like that proposed workflow.
I've also been wondering if we could consider choosing a different
product for patch reviews that supports our desired workflow better,
such as Gitlab or Phorge (the new Phabricator project).
If anyone would be willing to donate money for colocation, I'd be happy
to move one or more of my servers into a datacenter and use them for
hosting TianoCore services.
--
Rebecca Cran
On 3/17/23 3:33 AM, Gerd Hoffmann wrote:
On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote:
Is this still a requirement since Laszlo's departure from the project?
I seem to recall it was him who made it a sticking point of moving to a
GitHub PR workflow originally with the requirement to have emails of
everything.
I think it is very useful to have everything on the mailing list for
a number of reasons:
(1) In my experience reviewing patches, especially more complex ones,
works better in email than in github PR workflows.
(2) github doesn't preserve stuff like a mail archive does. When a
patch series goes through multiple revision github only preserves
the latest revision which was actually merged.
(3) Search engines seem to be better in indexing mail list archives
than github pull requests.
Nevertheless I see some room for improvement in our current workflow.
Developers often open a PR anyway for to run the CI. So maybe we could
automate sending the emails and also avoid running CI twice by avoiding
both developer and maintainer opening a PR, with a workflow like this:
* developer opens a draft PR to run CI for the patch series.
* when the series passes CI and is ready un-draft the PR.
* github action sends the patch series to the edk2-devel list
for review (maybe only after CI passed ...).
* patch review happens on the list.
* in case the developer pushes updates to the branch in response to
review comments the github action posts v2/v3 of the series too.
* once review is done merge the PR.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101329): https://edk2.groups.io/g/devel/message/101329
Mute This Topic: https://groups.io/mt/97636248/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
