Could someone commit this please?
On 12/5/22 19:17, Gao, Zhichao wrote:
Reviewed-by: Zhichao Gao <[email protected]>
Thanks,
Zhichao
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Rebecca
Cran
Sent: Friday, December 2, 2022 5:50 AM
To: [email protected]; Ni, Ray <[email protected]>; Gao, Zhichao
<[email protected]>
Cc: Rebecca Cran <[email protected]>
Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding
equals sign after time
The output of the "ping" command shows the time without a space between
the label and the value. e.g.:
20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms
Improve the readability and consistency by adding an equals sign for the time
value:
20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2ms
Signed-off-by: Rebecca Cran <[email protected]>
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm
andsLib.uni | 2 +-
ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm
andsLib.uni | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
mandsLib.uni
b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
mandsLib.uni
index 73cf96d9e614..37fd4a11929c 100644
---
a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
mandsLib.uni
+++
b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
+++ mandsLib.uni
@@ -52,7 +52,7 @@
#string STR_PING_NOROUTE_FOUND #language en-US "There is no
route to the destination '%B%s%N' from the source '%B%s%N' was
found.\r\n"
#string STR_PING_START #language en-US "Ping %s %d data
bytes.\r\n"
#string STR_PING_TIMEOUT #language en-US "Echo request
sequence %d timeout.\r\n"
-#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s :
icmp_seq=%d ttl=%d time%d~%dms\r\n"
+#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s :
icmp_seq=%d ttl=%d time=%d~%dms\r\n"
#string STR_PING_STAT #language en-US "\n%d packets
transmitted, %d received, %d%% packet loss, time %dms\r\n"
#string STR_PING_RTT #language en-US "\nRtt(round trip time)
min=%d~%dms max=%d~%dms avg=%d~%dms\r\n"
diff --git
a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
mandsLib.uni
b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
mandsLib.uni
index 30913ae5b583..cb9d39a33fbe 100644
---
a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
mandsLib.uni
+++
b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
+++ mandsLib.uni
@@ -33,7 +33,7 @@
#string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No
sources in %s's multicast domain.\r\n"
#string STR_PING6_START #language en-US "Ping %s %d data
bytes\r\n"
#string STR_PING6_TIMEOUT #language en-US "Echo request
sequence %d timeout.\r\n"
-#string STR_PING6_REPLY_INFO #language en-US "%d bytes
from %s : icmp_seq=%d ttl=%d time%d~%dms\r\n"
+#string STR_PING6_REPLY_INFO #language en-US "%d bytes
from %s : icmp_seq=%d ttl=%d time=%d~%dms\r\n"
#string STR_PING6_STAT #language en-US "\n%d packets
transmitted, %d received, %d%% packet loss, time %dms\r\n"
#string STR_PING6_RTT #language en-US "\nRtt(round trip
time)
min=%d~%dms max=%d~%dms avg=%d~%dms\r\n"
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100383): https://edk2.groups.io/g/devel/message/100383
Mute This Topic: https://groups.io/mt/95394121/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
