Thank you Liming. Ray has completed the review and I have pushed the PR branch with the Rb. I will add push label after CI passes.
Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via > groups.io > Sent: Wednesday, February 8, 2023 5:07 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; devel@edk2.groups.io > Cc: Cole, Deric <deric.c...@intel.com>; 'Andrew Fish' <af...@apple.com>; Ni, > Ray <ray...@intel.com> > Subject: 回复: [edk2-devel] [Patch 1/1] EmulatorPkg/PeiTimerLib: Bug fix in > NanoSecondDelay > > Mike: > This fix is OK to me. I am OK to merge it for this stable tag. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Kinney, Michael D <michael.d.kin...@intel.com> > > 发送时间: 2023年2月9日 7:17 > > 收件人: devel@edk2.groups.io; Kinney, Michael D > > <michael.d.kin...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn> > > 抄送: Cole, Deric <deric.c...@intel.com>; Andrew Fish <af...@apple.com>; > > Ni, Ray <ray...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> > > 主题: RE: [edk2-devel] [Patch 1/1] EmulatorPkg/PeiTimerLib: Bug fix in > > NanoSecondDelay > > > > Hi Liming, > > > > This is a significant behavior bug in EmulatorPkg PeiTimerLib that was > > discovered during the soft freeze evaluation period. > > > > I would like to request this patch be included in the edk2-stable202302 > > release. > > > > Thanks, > > > > Mike > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > > D Kinney > > > Sent: Wednesday, February 8, 2023 3:10 PM > > > To: devel@edk2.groups.io > > > Cc: Cole, Deric <deric.c...@intel.com>; Andrew Fish <af...@apple.com>; > > Ni, Ray <ray...@intel.com> > > > Subject: [edk2-devel] [Patch 1/1] EmulatorPkg/PeiTimerLib: Bug fix in > > NanoSecondDelay > > > > > > From: Deric Cole <deric.c...@intel.com> > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4339 > > > > > > Thunk->Sleep is expecting nanoseconds, no need to multiply by 100. > > > > > > Cc: Andrew Fish <af...@apple.com> > > > Cc: Ray Ni <ray...@intel.com> > > > Signed-off-by: Deric Cole <deric.c...@intel.com> > > > Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com> > > > --- > > > EmulatorPkg/Include/Protocol/EmuThunk.h | 2 +- > > > EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.c | 4 ++-- > > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/EmulatorPkg/Include/Protocol/EmuThunk.h > > b/EmulatorPkg/Include/Protocol/EmuThunk.h > > > index b720023ac9c7..c419d0a67790 100644 > > > --- a/EmulatorPkg/Include/Protocol/EmuThunk.h > > > +++ b/EmulatorPkg/Include/Protocol/EmuThunk.h > > > @@ -130,7 +130,7 @@ UINT64 > > > typedef > > > VOID > > > (EFIAPI *EMU_SLEEP)( > > > - IN UINT64 Milliseconds > > > + IN UINT64 Nanoseconds > > > ); > > > > > > typedef > > > diff --git a/EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.c > > b/EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.c > > > index 8c4f20f42b47..5344719f98d8 100644 > > > --- a/EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.c > > > +++ b/EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.c > > > @@ -1,7 +1,7 @@ > > > /** @file > > > A non-functional instance of the Timer Library. > > > > > > - Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR> > > > + Copyright (c) 2007 - 2023, Intel Corporation. All rights reserved.<BR> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -65,7 +65,7 @@ NanoSecondDelay ( > > > ); > > > if (!EFI_ERROR (Status)) { > > > Thunk = (EMU_THUNK_PROTOCOL *)ThunkPpi->Thunk (); > > > - Thunk->Sleep (NanoSeconds * 100); > > > + Thunk->Sleep (NanoSeconds); > > > return NanoSeconds; > > > } > > > > > > -- > > > 2.37.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99831): https://edk2.groups.io/g/devel/message/99831 Mute This Topic: https://groups.io/mt/96844651/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
