I pushed this here https://github.com/tianocore/edk2/pull/3994
but I am getting weird errors from the CI An error occurred while provisioning resources (Error Type: Failure). Build_VS2019 TARGET_FMP_FAT_TEST The remote provider was unable to process the request. Build_VS2019 TARGET_FMP_FAT_TEST without any explanation on how I am expected to mitigate this. Sean, Michael: can we fix this please? On Fri, 3 Feb 2023 at 12:16, Sunil V L <suni...@ventanamicro.com> wrote: > > Thanks a lot!, Ard. > > Reviewed-by: Sunil V L <suni...@ventanamicro.com> > > > On Fri, Feb 03, 2023 at 12:08:43PM +0100, Ard Biesheuvel wrote: > > The code never references the PCD so the INF should not reference it > > either. The last reference was moved to PrePiHobLib in commit > > 05e48e00834b32e4bd2 (dated 2011!) and dropped from there as well in > > commit 97106391955337155e7. > > > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > Cc: Abner Chang <abner.ch...@amd.com> > > Cc: Daniel Schaefer <g...@danielschaefer.me> > > Reported-by: Sunil V L <suni...@ventanamicro.com> > > Signed-off-by: Ard Biesheuvel <a...@kernel.org> > > --- > > EmbeddedPkg/Library/PrePiLib/PrePiLib.inf | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > index 3c749ca22943..090bfe888f52 100644 > > --- a/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > +++ b/EmbeddedPkg/Library/PrePiLib/PrePiLib.inf > > @@ -58,8 +58,6 @@ [Protocols] > > > > > > [FixedPcd.common] > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > - > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType > > -- > > 2.39.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99566): https://edk2.groups.io/g/devel/message/99566 Mute This Topic: https://groups.io/mt/96720569/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
