Hi Ard, I have no objections. For the patch series,
Acked-by: Bob Feng <bob.c.f...@intel.com> Thanks, Bob -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel Sent: Saturday, January 28, 2023 1:00 AM To: devel@edk2.groups.io; rebe...@bsdio.com; Gao, Liming <gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com> Cc: Leif Lindholm <quic_llind...@quicinc.com>; Chen, Christine <yuwei.c...@intel.com>; Marvin Häuser <mhaeu...@posteo.de> Subject: Re: [edk2-devel] [PATCH v2 0/4] BaseTools,ArmPkg,ArmVirtPkg: Remove leftover RVCT and RealView Debugger support On Fri, 27 Jan 2023 at 17:43, Rebecca Cran <rebe...@bsdio.com> wrote: > > Personal PR: https://github.com/tianocore/edk2/pull/3958 > > Changes from v1 to v2: > > Removed reference to CYGWIN_NT-5.1-i686 from Scripts/PatchCheck.py > Removed RealView Debugger support and references. > > Rebecca Cran (4): > BaseTools: Delete Bin/{CYGWIN_NT-5.1-i686,Darwin-i386} directories > BaseTools: Remove CYGWIN_NT-5.1-i686 ref from Scripts/PatchCheck.py > ArmPkg: Remove RealView Debugger support > ArmVirtPkg: Remove RealView Debugger lines from ArmVirtPkg.dsc.inc > Thanks for the respin. For the series, Acked-by: Ard Biesheuvel <a...@kernel.org> Liming, Bob: unless there are any objections, I intend to merge this, including the BaseTools/ changes, beginning of next week. Thanks, Ard. > ArmVirtPkg/ArmVirt.dsc.inc | > 7 - > ArmPkg/ArmPkg.dsc | > 1 - > ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf | > 35 ----- > ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | > 5 - > ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.c | > 147 -------------------- > BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv | > 5 - > BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc | > 14 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32 | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex | > 14 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds | > 14 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress | > 17 --- > BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource | > 5 - > BaseTools/Bin/CYGWIN_NT-5.1-i686/Split | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool | > 14 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim | > 14 -- > BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo | > 29 ---- > BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py | > 87 ------------ > BaseTools/Bin/CYGWIN_NT-5.1-i686/build | > 14 -- > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE31/CompilerIntrinsicsLib.lib | > Bin 36072 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib | > Bin 36072 -> 0 bytes > > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.lib | Bin > 11504 -> 0 bytes > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/CompilerIntrinsicsLib.lib | Bin > 11504 -> 0 bytes > BaseTools/Scripts/PatchCheck.py | > 1 - > 37 files changed, 887 deletions(-) > delete mode 100644 > ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf > delete mode 100644 > ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.c > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/BootSectImage > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/BuildEnv > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Ecc > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiLdrImage > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/EfiRom > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenCrc32 > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenDepex > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFds > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFfs > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFv > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenFw > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenPage > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenSec > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GenVtf > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/GnuGenBootSector > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaCompress > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/LzmaF86Compress > delete mode 100755 > BaseTools/Bin/CYGWIN_NT-5.1-i686/RunBinToolFromBuildDir > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/RunToolFromSource > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Split > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/TargetTool > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/TianoCompress > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/Trim > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/VfrCompile > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/VolInfo > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/armcc_wrapper.py > delete mode 100755 BaseTools/Bin/CYGWIN_NT-5.1-i686/build > delete mode 100644 > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE31/CompilerIntrinsicsLib.lib > delete mode 100644 > BaseTools/Bin/Darwin-i386/Arm/DEBUG_XCODE32/CompilerIntrinsicsLib.lib > delete mode 100644 > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE31/CompilerIntrinsicsLib.li > b delete mode 100644 > BaseTools/Bin/Darwin-i386/Arm/RELEASE_XCODE32/CompilerIntrinsicsLib.li > b > > -- > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99272): https://edk2.groups.io/g/devel/message/99272 Mute This Topic: https://groups.io/mt/96569697/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
