On Thu, 26 Jan 2023 at 13:06, Gierszynski, Przemyslaw <przemyslaw.gierszyn...@intel.com> wrote: > > Hi All, > > My name is Przemysław Gierszyński and I work as a Firmware Engineer in Intel > Technology Poland. > I was doing some work that required review of some parts of EDK2 and I think > I have found a small bug in ArmPkg module. > Here below are some details concerning the issue: > File: edk2/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c > Function: TimerContructor ( VOID ) – line 56 > Description: > The comment above says: “If the security extension is not implemented, set > Timer Frequency here.”. > In releases from the past in the if condition there was direct accessing to > ID_PFR1, and it was changed in the commit shown below. > > But if we go into the body of the ArmHasSecurityExtensions () function, we > can see that the result of the function is a negation of the condition from > the past: > > > Proposal of solution: > Change the if condition in TimerContructor () function from: if > (ArmHasSecurityExtensions ()) to if (!ArmHasSecurityExtensions ()) >
Good catch! Please submit a patch to the mailing list. Thanks, Ard. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#99155): https://edk2.groups.io/g/devel/message/99155 Mute This Topic: https://groups.io/mt/96551253/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
