Hi Sami,
I think other platforms have the same library missing:
- Platform/Hisilicon/D03/D03.dsc
- Platform/Hisilicon/D06/D06.dsc
- Platform/Hisilicon/HiKey960/HiKey960.dsc
- Platform/Hisilicon/HiKey/HiKey.dsc
If the library definition is done in Silicon/Hisilicon/Hisilicon.dsc.inc,
I think it solves all the definitions at once,
Regards,
Pierre
On 1/19/23 17:14, Sami Mujawar wrote:
From: Guillaume Gardet <guillaume.gar...@arm.com>
The Hisilicon/HiKey and Hisilicon/HiKey960 platform firmware builds
break due to a missing dependency on VariableFlashInfoLib.
Therefore, include VariableFlashInfoLib in the [LibraryClasses.common]
section to satisfy the dependency.
Cc: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Wenyi Xie <xiewen...@huawei.com>
Cc: Guillaume Gardet <guillaume.gar...@arm.com>
Cc: Pierre Gondois <pierre.gond...@arm.com>
Signed-off-by: Sami Mujawar <sami.muja...@arm.com>
---
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc
b/Platform/Hisilicon/HiKey/HiKey.dsc
index
375b29375d75cec37eb7410a8ea4396b6cdf89a4..c0de67fce8fe3a76cb6eca7f54814d676939f3e9
100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -62,6 +62,7 @@ [LibraryClasses.common]
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+
VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
[LibraryClasses.common.SEC]
PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc
b/Platform/Hisilicon/HiKey960/HiKey960.dsc
index
1d09e3f5da74824af3b988a55c646c1b127a3a93..b821f0be60e31507bee8d4358e15fc5eedaf133e
100644
--- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
+++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
@@ -63,6 +63,7 @@ [LibraryClasses.common]
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
+
VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
[LibraryClasses.common.SEC]
PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98958): https://edk2.groups.io/g/devel/message/98958
Mute This Topic: https://groups.io/mt/96380635/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-