BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237
Commit 9fdc70af6ba8 breaks log analysis and code cohesion in
AcpiPlatformDxe. See the detailed information in BZ#4237.
This patch-set contains below patches to fix above issues.
#1: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL and delete
QemuAcpiTableNotify.h.
#2: Use local variable of ChAcpiHandle to store the handle.
#3: Use local variable of QemuAcpiHandle to store the handle.
#4: Add log to show how many ACPI tables installed.
#5: Refactor the installation of QemuAcpiTableNotifyProtocol and
its error handling.
#6: Return error code if QemuAcpiTableNotifyProtocol is failed to be
installed so that the caller can handle the error.
Code: https://github.com/mxu9/edk2/tree/AcpiPlatformDxe.v2
v2 changes:
- Split v1 patch into 6 separate patches.
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Erdem Aktas <erdemak...@google.com>
Cc: James Bottomley <j...@linux.ibm.com>
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Tom Lendacky <thomas.lenda...@amd.com>
Cc: Sebastien Boeuf <sebastien.bo...@intel.com>
Reported-by: Laszlo Ersek <ler...@redhat.com>
Signed-off-by: Min Xu <min.m...@intel.com>
Min M Xu (6):
OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL
OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c
OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c
OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables
OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol
OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol
failed
OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 27 ++++++------
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 44 ++++++++++++-------
.../Include/Protocol/QemuAcpiTableNotify.h | 27 ------------
3 files changed, 43 insertions(+), 55 deletions(-)
delete mode 100644 OvmfPkg/Include/Protocol/QemuAcpiTableNotify.h
--
2.29.2.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98182): https://edk2.groups.io/g/devel/message/98182
Mute This Topic: https://groups.io/mt/96152492/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
