Reviewed-by: Igor Kulchytskyy<ig...@ami.com>
-----Original Message-----
From: Nickle Wang <nick...@nvidia.com>
Sent: Wednesday, December 28, 2022 1:28 AM
To: abner.ch...@amd.com; devel@edk2.groups.io
Cc: Igor Kulchytskyy <ig...@ami.com>
Subject: [EXTERNAL] RE: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB
Interface V2 update
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Reviewed-by: Nickle Wang<nick...@nvidia.com>
Regards,
Nickle
-----Original Message-----
From: abner.ch...@amd.com <abner.ch...@amd.com>
Sent: Wednesday, December 28, 2022 1:14 PM
To: devel@edk2.groups.io
Cc: Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>
Subject: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update
External email: Use caution opening links or attachments
From: Abner Chang <abner.ch...@amd.com>
Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host
Interface spec v1.3.
Signed-off-by: Abner Chang <abner.ch...@amd.com>
Cc: Nickle Wang <nick...@nvidia.com>
Cc: Igor Kulchytskyy <ig...@ami.com>
---
.../IndustryStandard/RedfishHostInterface.h | 25 ++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h
b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h
index 49b3ceee39c..022bd1f36ef 100644
--- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h
+++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h
@@ -3,6 +3,7 @@
Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights
+ reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@
#define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01
#define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02
+///
+/// Definitions for IP assignment tyeps.
+///
+typedef enum {
+ RedfishHostIpAssignmentUnknown,
+ RedfishHostIpAssignmentStatic,
+ RedfishHostIpAssignmentDhcp,
+ RedfishHostIpAssignmentAutoConfigure,
+ RedfishHostIpAssignmentHostSelected,
+ RedfishHostIpAssignmentReserved
+} REDFISH_HOST_IP_ASSIGNMENT;
+
#pragma pack(1)
///
/// Structure definitions of Host Interface device type 04h (USB Network
Interface V2) @@ -40,12 +53,18 @@ typedef struct {
///< idVendor field of the USB
descriptor.
UINT16 IdProduct; ///< The Product ID of the device,
as read from the
///< idProduct field of the USB
descriptor.
- UINT8 SecialNumberStr; ///< The string number for the
Serial Number of the
+ UINT8 SerialNumberStr; ///< The string number for the
Serial Number of the
///< device. The string data is
read from the
///< iSerialNumber.bDescriptorType
field of the USB
///< descriptor, and is converted
from Unicode to ASCII
///< and is NULL terminated.
UINT8 MacAddress[6]; ///< The MAC address of the
PCI/PCIe network device.
+
+ ///
+ /// Below is defined in Redfish Host Interface spec v1.3 ///
+ UINT16 Characteristics; ///< Additional device
characteristics.
+ UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping
handle.
} USB_INTERFACE_DEVICE_DESCRIPTOR_V2;
//
@@ -74,6 +93,10 @@ typedef struct {
///
/// Define union for the Host Interface Device Descriptor ///
+#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Length
USB interface device v2 defined in
+ ///< Redfish
host interface spec v1.3
+#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Length
USB interface device v2 defined in
+ ///<
+Redfish host interface spec v1.2
typedef union {
USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Device
type USB V2 device discriptor.
PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Device
type PCI/PCIe V2 device discriptor.
--
2.37.1.windows.1
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is intended to be read only by
the individual or entity to whom it is addressed or by their designee. If the
reader of this message is not the intended recipient, you are on notice that
any distribution of this message, in any form, is strictly prohibited. Please
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and
then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97784): https://edk2.groups.io/g/devel/message/97784
Mute This Topic: https://groups.io/mt/95915835/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
