Re: [edk2-devel] [PATCH 1/3] ArmPkg/ArmTrngLib: Fix incorrect GUID reference in DEBUG() output

[Sami Mujawar]

Hi Ard,

Thank you for this fix.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 10/11/2022, 13:48, "Ard Biesheuvel" <a...@kernel.org> wrote:

    ArmTrngLib crashes when run in DEBUG mode due to the fact that it passed
    the [truncated] GUID value to a DEBUG() print statement instead of a
    pointer to the GUID which is what the %g conversion expects.

    Signed-off-by: Ard Biesheuvel <a...@kernel.org>
    ---
     ArmPkg/Library/ArmTrngLib/ArmTrngLib.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c 
b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
    index b974a9423880..fdabc02cd39c 100644
    --- a/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
    +++ b/ArmPkg/Library/ArmTrngLib/ArmTrngLib.c
    @@ -375,7 +375,7 @@ ArmTrngLibConstructor (
         "FW-TRNG: Version %d.%d, GUID {%g}\n",

         MajorRev,

         MinorRev,

    -    Guid

    +    &Guid

         ));



       DEBUG_CODE_END ();

    -- 
    2.35.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96193): https://edk2.groups.io/g/devel/message/96193
Mute This Topic: https://groups.io/mt/94935840/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-