In dec file, it have compatibility for [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] In UefiPayloadPkg.dsc, in the same time it only choose one of these attributes, so on UefiPayloadPkg is choosing DynamicEx PCD as its attribute.
Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang Sent: Thursday, November 10, 2022 10:11 AM To: Ni; Ni, Ray <ray...@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. Yes, these pcds is used by PciBus driver, my comment is not correct. My intention is these PCDs have no value in the UefiPaylodPkd.dsc, we can use the default values in MdeModulePkg.dec or override the values in UefiPaylodPkd.dsc. On Thu, Nov 10, 2022 at 09:58 AM, Ni, Ray wrote: These PCDs are used by PciBus driver and MP init logic which are included in the UefiPayloadPkg. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Jiading Zhang Sent: Thursday, November 10, 2022 9:53 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: remove the redundant PCD definition. The following PCDs have no value in the file of UefiPayloadPkg.dsc, and they are not used in UefiPayloadPkg, so remove them from [PcdsDynamicExDefault] section. gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize Signed-off-by: jdzhang <jdzh...@kunluntech.com.cn<mailto:jdzh...@kunluntech.com.cn>> --- UefiPayloadPkg/UefiPayloadPkg.dsc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 1150be6acd..43768909b3 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -530,14 +530,6 @@ gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|$(UART_DEFAULT_PARITY) gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|$(UART_DEFAULT_STOP_BITS) gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|$(DEFAULT_TERMINAL_TYPE) - gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdMrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport - gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSystemPageSize - gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds - gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress - gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize !if ($(TARGET) == DEBUG || $(USE_CBMEM_FOR_CONSOLE) == TRUE) gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE !else -- 2.38.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96177): https://edk2.groups.io/g/devel/message/96177 Mute This Topic: https://groups.io/mt/94928007/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
