Prakash:
I don't see the reason for the change of I2CSlaveAddress. Can you help to
add it?
And, can you create pull request for this patch and make sure it pass open
CI?
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Prakash K via
> groups.io
> 发送时间: 2022年8月26日 12:08
> 收件人: gaolim...@byosoft.com.cn; devel@edk2.groups.io
> 抄送: Vasudevan Sambandan <vasudev...@ami.com>; Sundaresan S
> <sundares...@ami.com>; Gayathri Thunuguntla <gayath...@ami.com>
> 主题: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields
in
> formatted manner
>
> Hi Gaoliming
>
> Regarding Bugzilla Bug 3755, I have sent the patch to devel@edk2.groups.io
> and you have updated that you have received the patch. But the changes are
> not merged into EDK2 source.
> The sent patch is in the below mail thread.
> Kindly let us know the status of Bug 3755.
>
> Thanks,
> Prakash K
>
> -----Original Message-----
> From: Prakash K <praka...@ami.com>
> Sent: Wednesday, December 29, 2021 5:37 PM
> To: devel@edk2.groups.io; Prakash K <praka...@ami.com>
> Cc: Vasudevan Sambandan <vasudev...@ami.com>; Sundaresan S
> <sundares...@ami.com>; Gayathri Thunuguntla <gayath...@ami.com>
> Subject: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted
> manner
>
> In smbiosview command, modified the below SMBIOS Type38 fields to display
> in formatted manner 1. Base Address 2. IPMI Specification Version 3. NV
> Storage Device Address 4. I2C Slave Address
>
> Signed-off-by: Prakash K<praka...@ami.com>
> ---
> .../SmbiosView/PrintInfo.c | 20
> +++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index b144600a25..0a8dd4afba 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -1158,10 +1158,22 @@ SmbiosPrintStructure (
> //
>
> case 38:
>
> DisplayIPMIDIBMCInterfaceType (Struct->Type38->InterfaceType,
> Option);
>
> - PRINT_STRUCT_VALUE_H (Struct, Type38, IPMISpecificationRevision);
>
> - PRINT_STRUCT_VALUE_H (Struct, Type38, I2CSlaveAddress);
>
> - PRINT_STRUCT_VALUE_H (Struct, Type38, NVStorageDeviceAddress);
>
> - PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
>
> + ShellPrintEx(-1,-1,L"IPMISpecificationRevision: %d.%d\n",
> + Struct->Type38->IPMISpecificationRevision >> 4,
>
> +
> + Struct->Type38->IPMISpecificationRevision & 0x0F);
>
> +
>
> + ShellPrintEx(-1, -1,L"I2CSlaveAddress: 0x%x\n",Struct->
> + Type38->I2CSlaveAddress >>1);
>
> +
>
> + if (Struct->Type38->NVStorageDeviceAddress == 0xFF) {
>
> + ShellPrintEx(-1,-1,L"NVStorageDevice: Not Present\n");
>
> + } else {
>
> + PRINT_STRUCT_VALUE_H (Struct, Type38,
> NVStorageDeviceAddress);
>
> + }
>
> +
>
> + if (Struct->Type38->InterfaceType ==
> + IPMIDeviceInfoInterfaceTypeSSIF) {
>
> + ShellPrintEx(-1, -1,L"BaseAddress: 0x%x\n",Struct-> Type38->
> + BaseAddress >>1);
>
> + } else {
>
> + PRINT_STRUCT_VALUE_LH (Struct, Type38, BaseAddress);
>
> + }
>
> break;
>
>
>
> //
>
> --
> 2.18.0.windows.1
>
> This e-mail is intended for the use of the addressee only and may contain
> privileged, confidential, or proprietary information that is exempt from
> disclosure under law. If you have received this message in error, please
inform
> us promptly by reply e-mail, then delete the e-mail and destroy any
printed
> copy. Thank you.
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95792): https://edk2.groups.io/g/devel/message/95792
Mute This Topic: https://groups.io/mt/94701863/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
