[AMD Official Use Only - General] Thanks for catching this!. V3 patch sent.
Abner > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Monday, October 31, 2022 9:59 AM > To: devel@edk2.groups.io; Chang, Abner <abner.ch...@amd.com> > Cc: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; > Kirkendall, Garrett <garrett.kirkend...@amd.com>; Grimes, Paul > <paul.gri...@amd.com>; Dong, Eric <eric.d...@intel.com>; Kumar, Rahul > R <rahul.r.ku...@intel.com> > Subject: RE: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: > Rename the common C file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > This patch will cause build failure because the INF file is not updated after > rename. > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, > > Abner via groups.io > > Sent: Sunday, October 30, 2022 9:02 PM > > To: devel@edk2.groups.io > > Cc: Abdul Lateef Attar <abdat...@amd.com>; Garrett Kirkendall > > <garrett.kirkend...@amd.com>; Paul Grimes <paul.gri...@amd.com>; > Dong, > > Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Kumar, Rahul R > > <rahul.r.ku...@intel.com> > > Subject: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: > > Rename the common C file > > > > From: Abner Chang <abner.ch...@amd.com> > > > > BZ# 4093: Abstract SmmCpuFeaturesLib for sharing common code > > > > Rename SmmCpuFeaturesLiCommon.c to > > IntelSmmCpuFeaturesLib, because it was developed specifically for > > Intel implementation. The code that can be shared by other archs or > > vendors will be stripped away and put in the common file in the next > > patch. > > > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > > Cc: Abdul Lateef Attar <abdat...@amd.com> > > Cc: Garrett Kirkendall <garrett.kirkend...@amd.com> > > Cc: Paul Grimes <paul.gri...@amd.com> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > --- > > .../{SmmCpuFeaturesLibCommon.c => IntelSmmCpuFeaturesLib.c} | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) rename > > UefiCpuPkg/Library/SmmCpuFeaturesLib/{SmmCpuFeaturesLibCommon.c > => > > IntelSmmCpuFeaturesLib.c} (100%) > > > > diff --git > > > a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c > > similarity index 100% > > rename from > > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > > rename to > > UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c > > -- > > 2.37.1.windows.1 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95767): https://edk2.groups.io/g/devel/message/95767 Mute This Topic: https://groups.io/mt/94663860/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-