[AMD Official Use Only - General]
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L > via groups.io > Sent: Saturday, October 15, 2022 12:48 AM > To: devel@edk2.groups.io > Cc: Eric Dong <eric.d...@intel.com>; Ray Ni <ray...@intel.com>; Rahul > Kumar <rahul1.ku...@intel.com> > Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V4 17/34] > UefiCpuPkg/CpuDxe: Refactor to allow other architectures > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > REF: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&data=05%7C01%7Ca > bner.chang%40amd.com%7C41895629d015414ff9bd08daae044add%7C3dd89 > 61fe4884e608e11a82d994e183d%7C0%7C0%7C638013630708017518%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=aO5v%2Fc7HtU > h9CkdqJniJ6tIMS4cV3RX48EiCRhN%2F3pY%3D&reserved=0 > > Currently, CpuDxe supports only X86 architecture. To add support for other > architectures like RISC-V, this need to be refactored. > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Signed-off-by: Sunil V L <suni...@ventanamicro.com> > --- > UefiCpuPkg/CpuDxe/CpuDxe.inf | 28 +++++++++++--------- > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuDxe.h | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuGdt.h | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuMp.h | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuPageTable.h | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuDxe.c | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuGdt.c | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuMp.c | 0 > UefiCpuPkg/CpuDxe/{ => Ia32X64}/CpuPageTable.c | 0 > 9 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.inf > b/UefiCpuPkg/CpuDxe/CpuDxe.inf index 235241899222..65961813f74b > 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.inf > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.inf > @@ -29,28 +29,30 @@ [LibraryClasses] > DebugLib > DxeServicesTableLib > MemoryAllocationLib > - MtrrLib > UefiBootServicesTableLib > UefiDriverEntryPoint > - LocalApicLib > - UefiCpuLib > UefiLib > CpuExceptionHandlerLib > HobLib > ReportStatusCodeLib > - MpInitLib > TimerLib > PeCoffGetEntryPointLib > > -[Sources] > - CpuDxe.c > - CpuDxe.h > - CpuGdt.c > - CpuGdt.h > - CpuMp.c > - CpuMp.h > - CpuPageTable.h > - CpuPageTable.c > +[LibraryClasses.IA32, LibraryClasses.X64] > + LocalApicLib > + MpInitLib > + MtrrLib > + UefiCpuLib I think we also need to refactor UefiCpuLib and MpInitLib when other archs have their own implementations. This patch needs maintainer's review. However, same comment as I gave earlier. We will have to wait until the File Naming and Directory naming sections are firmed and published in edk2 coding standard spec. Abner > + > +[Sources.IA32, Sources.X64] > + Ia32X64/CpuDxe.c > + Ia32X64/CpuDxe.h > + Ia32X64/CpuGdt.c > + Ia32X64/CpuGdt.h > + Ia32X64/CpuMp.c > + Ia32X64/CpuMp.h > + Ia32X64/CpuPageTable.h > + Ia32X64/CpuPageTable.c > > [Sources.IA32] > Ia32/CpuAsm.nasm > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuDxe.h > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuDxe.h > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuDxe.h > diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.h > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuGdt.h > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuGdt.h > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuGdt.h > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.h > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuMp.h > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuMp.h > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuMp.h diff --git > a/UefiCpuPkg/CpuDxe/CpuPageTable.h > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuPageTable.h > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuPageTable.h rename to > UefiCpuPkg/CpuDxe/Ia32X64/CpuPageTable.h > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuDxe.c > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuDxe.c > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuDxe.c > diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuGdt.c > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuGdt.c > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuGdt.c > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuMp.c > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuMp.c > rename to UefiCpuPkg/CpuDxe/Ia32X64/CpuMp.c diff --git > a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/Ia32X64/CpuPageTable.c > similarity index 100% > rename from UefiCpuPkg/CpuDxe/CpuPageTable.c rename to > UefiCpuPkg/CpuDxe/Ia32X64/CpuPageTable.c > -- > 2.38.0 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95270): https://edk2.groups.io/g/devel/message/95270 Mute This Topic: https://groups.io/mt/94330845/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
