[AMD Official Use Only - General] No problem with this change. Same comment as I gave earlier. We will have to wait until the File Naming and Directory naming sections are firmed and published in edk2 coding standard spec.
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L > via groups.io > Sent: Saturday, October 15, 2022 12:48 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>; Jiewen Yao > <jiewen....@intel.com>; Jordan Justen <jordan.l.jus...@intel.com>; Gerd > Hoffmann <kra...@redhat.com>; Rebecca Cran <rebe...@bsdio.com>; > Peter Grehan <gre...@freebsd.org> > Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V4 07/34] > OvmfPkg/ResetSystemLib: Refactor to allow other architectures. > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > REF: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&data=05%7C01%7Ca > bner.chang%40amd.com%7C4afeba80fc664a8cd6ce08daae041516%7C3dd896 > 1fe4884e608e11a82d994e183d%7C0%7C0%7C638013629820725576%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=c8BbNEAHoBqI > Hw%2BEWw%2FPubX5f4gFv%2FFR709YdBeE41Q%3D&reserved=0 > > Currently, the ResetSystemLib library supports only X86 architecture. > Refactor it to allow adding other CPU architectures like RISC-V. > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Rebecca Cran <rebe...@bsdio.com> > Cc: Peter Grehan <gre...@freebsd.org> > Signed-off-by: Sunil V L <suni...@ventanamicro.com> > --- > OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf | 6 > +++- > -- > OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf | 4 > ++-- > OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibMicrovm.inf | 2 > +- > OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf | 6 > +++-- > - > OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.inf | 4 > ++-- > OvmfPkg/Library/ResetSystemLib/{ => Ia32X64}/BaseResetShutdown.c | > 0 > OvmfPkg/Library/ResetSystemLib/{ => > Ia32X64}/BaseResetShutdownBhyve.c | 0 > OvmfPkg/Library/ResetSystemLib/{ => Ia32X64}/DxeResetShutdown.c | > 0 > OvmfPkg/Library/ResetSystemLib/{ => > Ia32X64}/DxeResetSystemLibMicrovm.c | 0 > OvmfPkg/Library/ResetSystemLib/{ => Ia32X64}/ResetSystemLib.c | 0 > OvmfPkg/Library/ResetSystemLib/{ => Ia32X64}/ResetSystemLibMicrovm.c > | 0 > 11 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > index 35d317f1e0b3..a554c6b68cfe 100644 > --- a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf > @@ -21,9 +21,9 @@ [Defines] > # VALID_ARCHITECTURES = IA32 X64 > # > > -[Sources] > - BaseResetShutdown.c > - ResetSystemLib.c > +[Sources.IA32, Sources.X64] > + Ia32X64/BaseResetShutdown.c > + Ia32X64/ResetSystemLib.c > > [Packages] > MdeModulePkg/MdeModulePkg.dec > diff --git a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf > b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf > index 74124aed38e8..882a8767cfa5 100644 > --- a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf > +++ b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibBhyve.inf > @@ -25,8 +25,8 @@ [Defines] > # > > [Sources] > - BaseResetShutdownBhyve.c > - ResetSystemLib.c > + Ia32X64/BaseResetShutdownBhyve.c > + Ia32X64/ResetSystemLib.c > > [Packages] > MdeModulePkg/MdeModulePkg.dec > diff --git > a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibMicrovm.inf > b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibMicrovm.inf > index 564b1d3022a6..8e73ac256bc7 100644 > --- a/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibMicrovm.inf > +++ b/OvmfPkg/Library/ResetSystemLib/BaseResetSystemLibMicrovm.inf > @@ -23,7 +23,7 @@ [Defines] > # > > [Sources] > - ResetSystemLibMicrovm.c > + Ia32X64/ResetSystemLibMicrovm.c > > [Packages] > MdeModulePkg/MdeModulePkg.dec > diff --git a/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > b/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > index a9b4ce90000a..acf9c6a93552 100644 > --- a/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLib.inf > @@ -23,9 +23,9 @@ [Defines] > # VALID_ARCHITECTURES = IA32 X64 > # > > -[Sources] > - DxeResetShutdown.c > - ResetSystemLib.c > +[Sources.IA32, Sources.X64] > + Ia32X64/DxeResetShutdown.c > + Ia32X64/ResetSystemLib.c > > [Packages] > MdeModulePkg/MdeModulePkg.dec > diff --git > a/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.inf > b/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.inf > index ac9c2599642c..918c8262fac7 100644 > --- a/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.inf > +++ b/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.inf > @@ -24,8 +24,8 @@ [Defines] > # > > [Sources] > - ResetSystemLibMicrovm.c > - DxeResetSystemLibMicrovm.c > + Ia32X64/ResetSystemLibMicrovm.c > + Ia32X64/DxeResetSystemLibMicrovm.c > > [Packages] > MdeModulePkg/MdeModulePkg.dec > diff --git a/OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/BaseResetShutdown.c > similarity index 100% > rename from OvmfPkg/Library/ResetSystemLib/BaseResetShutdown.c > rename to OvmfPkg/Library/ResetSystemLib/Ia32X64/BaseResetShutdown.c > diff --git a/OvmfPkg/Library/ResetSystemLib/BaseResetShutdownBhyve.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/BaseResetShutdownBhyve.c > similarity index 100% > rename from > OvmfPkg/Library/ResetSystemLib/BaseResetShutdownBhyve.c > rename to > OvmfPkg/Library/ResetSystemLib/Ia32X64/BaseResetShutdownBhyve.c > diff --git a/OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/DxeResetShutdown.c > similarity index 100% > rename from OvmfPkg/Library/ResetSystemLib/DxeResetShutdown.c > rename to OvmfPkg/Library/ResetSystemLib/Ia32X64/DxeResetShutdown.c > diff --git a/OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/DxeResetSystemLibMicrovm.c > similarity index 100% > rename from > OvmfPkg/Library/ResetSystemLib/DxeResetSystemLibMicrovm.c > rename to > OvmfPkg/Library/ResetSystemLib/Ia32X64/DxeResetSystemLibMicrovm.c > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/ResetSystemLib.c > similarity index 100% > rename from OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c > rename to OvmfPkg/Library/ResetSystemLib/Ia32X64/ResetSystemLib.c > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c > b/OvmfPkg/Library/ResetSystemLib/Ia32X64/ResetSystemLibMicrovm.c > similarity index 100% > rename from OvmfPkg/Library/ResetSystemLib/ResetSystemLibMicrovm.c > rename to > OvmfPkg/Library/ResetSystemLib/Ia32X64/ResetSystemLibMicrovm.c > -- > 2.38.0 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95259): https://edk2.groups.io/g/devel/message/95259 Mute This Topic: https://groups.io/mt/94330828/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
