On Wed, Oct 12, 2022 at 07:35:23AM +0000, Oliver Steffen wrote:
> Initialize
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
> with with the value of the variable "FIRMWARE_VER"
> in all flavors of ArmVirtPkg.
>
> This behavior is already implemented in ArmVirtXen.dsc.
> It allows specifying the firmware version string on the
> build command line with -D FIRMARE_VER=...
I think we need to decide which approach we want support for
setting PcdFirmwareVersionString (and write it down in armvirt/ovmf
readme).
The options we have are:
(1) -D "FIRMARE_VER=${version}" (needs this patch), or
(2) --pcd "PcdFirmwareVersionString=L'${version}\\0'"
Advantage of (1) is that the build command line is a bit simpler.
Disadvantage of (1) is that it overrides PcdFirmwareVersionString
even in case FIRMARE_VER is not set on the command line. Which doesn't
make much of a difference today because the default value defined in
MdeModulePkg is just the empty string. In case we set the default
to something more useful (https://edk2.groups.io/g/devel/message/94985)
overriding it is not so nice though ...
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95063): https://edk2.groups.io/g/devel/message/95063
Mute This Topic: https://groups.io/mt/94276443/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
