On 9/29/22 14:53, Adrien Thierry wrote:
This patch series does a few fixes in the SyncPcie() function, more
specifically in the logic that deletes the pci node to prevent Linux from
resetting the XHCI controller.
Hmm, that code not being exactly right isn't surprising, I went through
about a dozen revisions looking for the one that fixed it consistently
and in the end this version worked with some older kernels (and likely
dt) but doesn't work with any of the recent ones.
But... I think I found an actual fix a couple months ago while testing
the DT->SMCCC pci config space code. Which is to update the ranges
property as well. With that change the firmware can reset the XHCI
controller in recent Linux's, so there isn't a need to remove the XHCI node.
There is a copy of the patch hiding on my github
https://github.com/jlinton/edk2-platforms/commit/50540bd24f93b633c3597b5dc58c1a1a3b49bf7f#diff-373e67aaa16dd9ac2428d5acc3d73ef218b2ed6d24f3350d5af558cba03cf5adR378
along with a change to update the compatible property to
pci-host-smc-generic and remove the ranges property which should be
ignored... :)
If you just add the range tweak, does that fix the XHCI config in your
setup too?
I really need to start getting many of those old/stale patches cleaned
up and merged, but its not been a high priority.
Adrien Thierry (2):
Platform/RaspberryPi: fix pci DT node address in SyncPcie()
Platform/RaspberryPi: delete usb node instead of pci in SyncPcie()
Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
base-commit: e55f0527dde48a5f139c1b8f35acc4e6b59dd794
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94572): https://edk2.groups.io/g/devel/message/94572
Mute This Topic: https://groups.io/mt/94002759/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
