Hi Aryeh,
Thank you for testing.
Reviewed-by: Ankit Sinha <ankit.si...@intel.com>
> -----Original Message-----
> From: Chen, Aryeh <aryeh.c...@intel.com>
> Sent: Wednesday, September 21, 2022 12:34 AM
> To: Sinha, Ankit <ankit.si...@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desim...@intel.com>; Oram, Isaac W
> <isaac.w.o...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>;
> Dong, Eric <eric.d...@intel.com>
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
>
> Hi Ankit,
>
> Add a change to remove Name(_ADR, 0x00000000) from edk2-
> platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl
> It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU
> openboard bios.
>
> === Acpidump ===
> Signature "DSDT"
> Length 0x000000FD (253)
> Revision 0x01 (1)
> Checksum 0x33 (51)
> OEM ID "INTEL "
> OEM Table ID "MIN "
> OEM Revision 0x00000000 (0)
> Creator ID "INTL"
> Creator Revision 0x20210930 (539035952)
> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN ", 0x00000000)
> {
> Scope(_SB)
> {
> Device(PCI0)
> {
> Name(_HID, EISAID("PNP0A08"))
> Name(_CID, EISAID("PNP0A03"))
> Name(_SEG, Zero)
> Method(^BN00, 0, NotSerialized)
> {
> Return(Zero)
> }
>
> === Original mindsdt.asl ===
> Scope(\_SB) {
>
> //---------------------------------------------------------------------------
> // Begin PCI tree object scope
>
> //---------------------------------------------------------------------------
> Device(PCI0) { // PCI Bridge "Host Bridge"
> Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy
> Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't
> understand the new HID
> Name(_SEG, 0)
> Name(_ADR, 0x00000000)
> Method(^BN00, 0){ return(0x0000) } // Returns default Bus number for
> Peer PCI busses. Name can be overriden with control method placed directly
> under Device scope
> Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root
> PCI Bus
>
> Thanks,
> Aryeh
>
> -----Original Message-----
> From: Sinha, Ankit <ankit.si...@intel.com>
> Sent: Tuesday, September 13, 2022 4:54 AM
> To: Chen, Aryeh <aryeh.c...@intel.com>; devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desim...@intel.com>; Oram, Isaac W
> <isaac.w.o...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>;
> Dong, Eric <eric.d...@intel.com>
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
>
> Hi Aryeh,
>
> Can you please post the test results for this change. It would be good to note
> that there is no change in behavior in the OS.
>
> Thank you,
> Ankit
>
> > -----Original Message-----
> > From: Chen, Aryeh <aryeh.c...@intel.com>
> > Sent: Sunday, September 11, 2022 10:18 PM
> > To: devel@edk2.groups.io
> > Cc: Chen, Aryeh <aryeh.c...@intel.com>; Chiu, Chasel
> > <chasel.c...@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desim...@intel.com>; Oram, Isaac W
> > <isaac.w.o...@intel.com>; Sinha, Ankit <ankit.si...@intel.com>; Gao,
> > Liming <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>
> > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> >
> > From: Aryeh Chen <aryeh.c...@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> >
> > According to ASL Coding Guidelines - Device Identifiers "A Device
> > should contain either an _ADR or a _HID object, never both."
> > , so remove _ADR due to _HID exist.
> >
> > Signed-off-by: Aryeh Chen <aryeh.c...@intel.com>
> > Cc: Chasel Chiu <chasel.c...@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
> > Cc: Isaac Oram <isaac.w.o...@intel.com>
> > Cc: Ankit Sinha <ankit.si...@intel.com>
> > Cc: Liming Gao <gaolim...@byosoft.com.cn>
> > Cc: Eric Dong <eric.d...@intel.com>
> > ---
> > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > index 0d94472450..4efb8709ac 100644
> > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > @@ -27,7 +27,6 @@ DefinitionBlock (
> > Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> > host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> > that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR,
> > 0x00000000) Method(^BN00, 0){ return(0x0000) } // Returns default Bus
> > number for Peer PCI busses. Name can be overriden with control method
> > placed directly under Device scope Method(_BBN, 0){ return(BN00()) }
> //
> > Bus number, optional for the Root PCI Bus Name(_UID, 0x0000) //
> Unique
> > Bus ID, optional--
> > 2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94486): https://edk2.groups.io/g/devel/message/94486
Mute This Topic: https://groups.io/mt/93627173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
