Nate or Sai, this series should be a quick review if you could please prioritize…
Benjamin, Your series is reviewed but breaks several builds due to unrelated changes. My plan is to get approval for mine, then submit both series as a batch to ensure bisect not broken. But I didn’t get a reviewed by or ack yet for my changes. If you review/send Reviewed-by then all I need is an Ack. And it may be that the others were waiting for your approval since my changes modify yours. Anytime I am included in a review, but am not a maintainer, I try to review as it isn’t approval to commit, but maintainers may want to see my thoughts. That is my interpretation anyway. There are no requirement for you to review, maintainer approval is the gate as I understand it. There are two paths. But if you integrate my changes into yours and send a new version, it is then signed off by both of us and we need a third reviewer anyway. Thus it seems easier to have Nate or Sai review my series. Regards. Isaac From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin Doron Sent: Wednesday, September 28, 2022 9:17 AM To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/2] Platforms/Intel: Build fixes Thanks, Isaac. Are these two S3 series ready to merge, or did I have more review to address? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94483): https://edk2.groups.io/g/devel/message/94483 Mute This Topic: https://groups.io/mt/93684404/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
