Hi Mike,
Okay, let me try.
Thanks,
Chao
> -----原始邮件-----
> 发件人: "Michael D Kinney" <michael.d.kin...@intel.com>
> 发送时间:2022-09-10 01:21:28 (星期六)
> 收件人: "Chao Li" <lic...@loongson.cn>, "devel@edk2.groups.io"
> <devel@edk2.groups.io>, "Kinney, Michael D" <michael.d.kin...@intel.com>
> 抄送: "Gao, Liming" <gaolim...@byosoft.com.cn>, "Liu, Zhiguang"
> <zhiguang....@intel.com>
> 主题: Re: [edk2-devel] [PATCH v1 24/34] MdePkg/BaseCacheMaintenanceLib:
> LoongArch cache maintenance implementation.
>
> Recommend avoiding use of inline assembly. Can you convert to .S?
>
> Mike
>
> > -----Original Message-----
> > From: Chao Li <lic...@loongson.cn>
> > Sent: Wednesday, September 7, 2022 9:52 PM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
> > <gaolim...@byosoft.com.cn>; Liu, Zhiguang
> > <zhiguang....@intel.com>
> > Subject: [PATCH v1 24/34] MdePkg/BaseCacheMaintenanceLib: LoongArch cache
> > maintenance implementation.
> >
> > Implement LoongArch cache maintenance functions in
> > BaseCacheMaintenanceLib.
> >
> > Cc: Michael D Kinney <michael.d.kin...@intel.com>
> > Cc: Liming Gao <gaolim...@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang....@intel.com>
> >
> > Signed-off-by: Chao Li <lic...@loongson.cn>
> > ---
> > .../BaseCacheMaintenanceLib.inf | 4 +
> > .../BaseCacheMaintenanceLib/LoongArchCache.c | 252 ++++++++++++++++++
> > 2 files changed, 256 insertions(+)
> > create mode 100644 MdePkg/Library/BaseCacheMaintenanceLib/LoongArchCache.c
> >
> > diff --git
> > a/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> > b/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> > index 33114243d5..e103705b2c 100644
> > --- a/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> > +++ b/MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf
> > @@ -7,6 +7,7 @@
> > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> >
> > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>
> >
> > # Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All
> > rights reserved.<BR>
> >
> > +# Copyright (c) 2022, Loongson Technology Corporation Limited. All rights
> > reserved.<BR>
> >
> > #
> >
> > # SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > #
> >
> > @@ -45,6 +46,9 @@
> > [Sources.RISCV64]
> >
> > RiscVCache.c
> >
> >
> >
> > +[Sources.LOONGARCH64]
> >
> > + LoongArchCache.c
> >
> > +
> >
> > [Packages]
> >
> > MdePkg/MdePkg.dec
> >
> >
> >
> > diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/LoongArchCache.c
> > b/MdePkg/Library/BaseCacheMaintenanceLib/LoongArchCache.c
> > new file mode 100644
> > index 0000000000..067b5def55
> > --- /dev/null
> > +++ b/MdePkg/Library/BaseCacheMaintenanceLib/LoongArchCache.c
> > @@ -0,0 +1,252 @@
> > +/** @file
> >
> > + Cache Maintenance Functions for LoongArch.
> >
> > + LoongArch cache maintenance functions has not yet been completed, and
> > will added in later.
> >
> > + Functions are null functions now.
> >
> > +
> >
> > + Copyright (c) 2022, Loongson Technology Corporation Limited. All rights
> > reserved.<BR>
> >
> > +
> >
> > + SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +//
> >
> > +// Include common header file for this module.
> >
> > +//
> >
> > +#include <Base.h>
> >
> > +#include <Library/BaseLib.h>
> >
> > +#include <Library/DebugLib.h>
> >
> > +
> >
> > +/**
> >
> > + Invalidates the entire instruction cache in cache coherency domain of the
> >
> > + calling CPU.
> >
> > +
> >
> > +**/
> >
> > +VOID
> >
> > +EFIAPI
> >
> > +InvalidateInstructionCache (
> >
> > + VOID
> >
> > + )
> >
> > +{
> >
> > + __asm__ __volatile__ (
> >
> > + "ibar 0\n"
> >
> > + :
> >
> > + :
> >
> > + );
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Invalidates a range of instruction cache lines in the cache coherency
> > domain
> >
> > + of the calling CPU.
> >
> > +
> >
> > + Invalidates the instruction cache lines specified by Address and Length.
> > If
> >
> > + Address is not aligned on a cache line boundary, then entire instruction
> >
> > + cache line containing Address is invalidated. If Address + Length is not
> >
> > + aligned on a cache line boundary, then the entire instruction cache line
> >
> > + containing Address + Length -1 is invalidated. This function may choose
> > to
> >
> > + invalidate the entire instruction cache if that is more efficient than
> >
> > + invalidating the specified range. If Length is 0, the no instruction
> > cache
> >
> > + lines are invalidated. Address is returned.
> >
> > +
> >
> > + If Length is greater than (MAX_ADDRESS - Address + 1), then ASSERT().
> >
> > +
> >
> > + @param[in] Address The base address of the instruction cache lines to
> >
> > + invalidate. If the CPU is in a physical addressing mode,
> > then
> >
> > + Address is a physical address. If the CPU is in a virtual
> >
> > + addressing mode, then Address is a virtual address.
> >
> > +
> >
> > + @param[in] Length The number of bytes to invalidate from the
> > instruction cache.
> >
> > +
> >
> > + @return Address.
> >
> > +
> >
> > +**/
> >
> > +VOID *
> >
> > +EFIAPI
> >
> > +InvalidateInstructionCacheRange (
> >
> > + IN VOID *Address,
> >
> > + IN UINTN Length
> >
> > + )
> >
> > +{
> >
> > + __asm__ __volatile__ (
> >
> > + "ibar 0\n"
> >
> > + :
> >
> > + :
> >
> > + );
> >
> > + return Address;
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Writes Back and Invalidates the entire data cache in cache coherency
> > domain
> >
> > + of the calling CPU.
> >
> > +
> >
> > + Writes Back and Invalidates the entire data cache in cache coherency
> > domain
> >
> > + of the calling CPU. This function guarantees that all dirty cache lines
> > are
> >
> > + written back to system memory, and also invalidates all the data cache
> > lines
> >
> > + in the cache coherency domain of the calling CPU.
> >
> > +
> >
> > +**/
> >
> > +VOID
> >
> > +EFIAPI
> >
> > +WriteBackInvalidateDataCache (
> >
> > + VOID
> >
> > + )
> >
> > +{
> >
> > + DEBUG ((DEBUG_ERROR, "%a: Not currently implemented on LoongArch.\n",
> > __FUNCTION__));
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Writes Back and Invalidates a range of data cache lines in the cache
> >
> > + coherency domain of the calling CPU.
> >
> > +
> >
> > + Writes Back and Invalidate the data cache lines specified by Address and
> >
> > + Length. If Address is not aligned on a cache line boundary, then entire
> > data
> >
> > + cache line containing Address is written back and invalidated. If
> > Address +
> >
> > + Length is not aligned on a cache line boundary, then the entire data
> > cache
> >
> > + line containing Address + Length -1 is written back and invalidated. This
> >
> > + function may choose to write back and invalidate the entire data cache if
> >
> > + that is more efficient than writing back and invalidating the specified
> >
> > + range. If Length is 0, the no data cache lines are written back and
> >
> > + invalidated. Address is returned.
> >
> > +
> >
> > + If Length is greater than (MAX_ADDRESS - Address + 1), then ASSERT().
> >
> > +
> >
> > + @param[in] Address The base address of the data cache lines to write
> > back and
> >
> > + invalidate. If the CPU is in a physical addressing mode,
> > then
> >
> > + Address is a physical address. If the CPU is in a virtual
> >
> > + addressing mode, then Address is a virtual address.
> >
> > + @param[in] Length The number of bytes to write back and invalidate
> > from the
> >
> > + data cache.
> >
> > +
> >
> > + @return Address of cache invalidation.
> >
> > +
> >
> > +**/
> >
> > +VOID *
> >
> > +EFIAPI
> >
> > +WriteBackInvalidateDataCacheRange (
> >
> > + IN VOID *Address,
> >
> > + IN UINTN Length
> >
> > + )
> >
> > +{
> >
> > + DEBUG ((DEBUG_ERROR, "%a: Not currently implemented on LoongArch.\n",
> > __FUNCTION__));
> >
> > + return Address;
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Writes Back the entire data cache in cache coherency domain of the
> > calling
> >
> > + CPU.
> >
> > +
> >
> > + Writes Back the entire data cache in cache coherency domain of the
> > calling
> >
> > + CPU. This function guarantees that all dirty cache lines are written
> > back to
> >
> > + system memory. This function may also invalidate all the data cache
> > lines in
> >
> > + the cache coherency domain of the calling CPU.
> >
> > +
> >
> > +**/
> >
> > +VOID
> >
> > +EFIAPI
> >
> > +WriteBackDataCache (
> >
> > + VOID
> >
> > + )
> >
> > +{
> >
> > + WriteBackInvalidateDataCache ();
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Writes Back a range of data cache lines in the cache coherency domain of
> > the
> >
> > + calling CPU.
> >
> > +
> >
> > + Writes Back the data cache lines specified by Address and Length. If
> > Address
> >
> > + is not aligned on a cache line boundary, then entire data cache line
> >
> > + containing Address is written back. If Address + Length is not aligned
> > on a
> >
> > + cache line boundary, then the entire data cache line containing Address +
> >
> > + Length -1 is written back. This function may choose to write back the
> > entire
> >
> > + data cache if that is more efficient than writing back the specified
> > range.
> >
> > + If Length is 0, the no data cache lines are written back. This function
> > may
> >
> > + also invalidate all the data cache lines in the specified range of the
> > cache
> >
> > + coherency domain of the calling CPU. Address is returned.
> >
> > +
> >
> > + If Length is greater than (MAX_ADDRESS - Address + 1), then ASSERT().
> >
> > +
> >
> > + @param[in] Address The base address of the data cache lines to write
> > back. If
> >
> > + the CPU is in a physical addressing mode, then Address
> > is a
> >
> > + physical address. If the CPU is in a virtual addressing
> >
> > + mode, then Address is a virtual address.
> >
> > + @param[in] Length The number of bytes to write back from the data
> > cache.
> >
> > +
> >
> > + @return Address of cache written in main memory.
> >
> > +
> >
> > +**/
> >
> > +VOID *
> >
> > +EFIAPI
> >
> > +WriteBackDataCacheRange (
> >
> > + IN VOID *Address,
> >
> > + IN UINTN Length
> >
> > + )
> >
> > +{
> >
> > + DEBUG ((DEBUG_ERROR, "%a: Not currently implemented on LoongArch.\n",
> > __FUNCTION__));
> >
> > + return Address;
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Invalidates the entire data cache in cache coherency domain of the
> > calling
> >
> > + CPU.
> >
> > +
> >
> > + Invalidates the entire data cache in cache coherency domain of the
> > calling
> >
> > + CPU. This function must be used with care because dirty cache lines are
> > not
> >
> > + written back to system memory. It is typically used for cache
> > diagnostics. If
> >
> > + the CPU does not support invalidation of the entire data cache, then a
> > write
> >
> > + back and invalidate operation should be performed on the entire data
> > cache.
> >
> > +
> >
> > +**/
> >
> > +VOID
> >
> > +EFIAPI
> >
> > +InvalidateDataCache (
> >
> > + VOID
> >
> > + )
> >
> > +{
> >
> > + __asm__ __volatile__ (
> >
> > + "dbar 0\n"
> >
> > + :
> >
> > + :
> >
> > + );
> >
> > +}
> >
> > +
> >
> > +/**
> >
> > + Invalidates a range of data cache lines in the cache coherency domain of
> > the
> >
> > + calling CPU.
> >
> > +
> >
> > + Invalidates the data cache lines specified by Address and Length. If
> > Address
> >
> > + is not aligned on a cache line boundary, then entire data cache line
> >
> > + containing Address is invalidated. If Address + Length is not aligned on
> > a
> >
> > + cache line boundary, then the entire data cache line containing Address +
> >
> > + Length -1 is invalidated. This function must never invalidate any cache
> > lines
> >
> > + outside the specified range. If Length is 0, the no data cache lines are
> >
> > + invalidated. Address is returned. This function must be used with care
> >
> > + because dirty cache lines are not written back to system memory. It is
> >
> > + typically used for cache diagnostics. If the CPU does not support
> >
> > + invalidation of a data cache range, then a write back and invalidate
> >
> > + operation should be performed on the data cache range.
> >
> > +
> >
> > + If Length is greater than (MAX_ADDRESS - Address + 1), then ASSERT().
> >
> > +
> >
> > + @param[in] Address The base address of the data cache lines to
> > invalidate. If
> >
> > + the CPU is in a physical addressing mode, then Address
> > is a
> >
> > + physical address. If the CPU is in a virtual addressing
> > mode,
> >
> > + then Address is a virtual address.
> >
> > + @param[in] Length The number of bytes to invalidate from the data
> > cache.
> >
> > +
> >
> > + @return Address.
> >
> > +
> >
> > +**/
> >
> > +VOID *
> >
> > +EFIAPI
> >
> > +InvalidateDataCacheRange (
> >
> > + IN VOID *Address,
> >
> > + IN UINTN Length
> >
> > + )
> >
> > +{
> >
> > + __asm__ __volatile__ (
> >
> > + "dbar 0\n"
> >
> > + :
> >
> > + :
> >
> > + );
> >
> > + return Address;
> >
> > +}
> >
> > --
> > 2.27.0
>
>
>
>
>
>
本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。
This email and its attachments contain confidential information from Loongson
Technology , which is intended only for the person or entity whose address is
listed above. Any use of the information contained herein in any way
(including, but not limited to, total or partial disclosure, reproduction or
dissemination) by persons other than the intended recipient(s) is prohibited.
If you receive this email in error, please notify the sender by phone or email
immediately and delete it.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93629): https://edk2.groups.io/g/devel/message/93629
Mute This Topic: https://groups.io/mt/93542557/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
