Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com>
> -----Original Message-----
> From: Benjamin Doron <benjamin.doro...@gmail.com>
> Sent: Tuesday, September 6, 2022 10:27 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Oram, Isaac W
> <isaac.w.o...@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desim...@intel.com>; Sinha, Ankit <ankit.si...@intel.com>;
> Chiu, Chasel <chasel.c...@intel.com>; Gao, Liming
> <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>
> Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3]
> MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib:
> First BoardInitLib
>
> SecBoardInitLib is called to enable serial port before SerialPortInitialize
> and
> DEBUG().
>
> This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in
> SEC phase, which presently initialises this way.
>
> No testing was performed before, it's assumed too risky unless the GPIO
> happens to have the desired default. Presently, DEBUG() works in SEC
> phase.
>
> Cc: Sai Chaganty <rangasai.v.chaga...@intel.com>
> Cc: Isaac Oram <isaac.w.o...@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
> Cc: Ankit Sinha <ankit.si...@intel.com>
> Cc: Chasel Chiu <chasel.c...@intel.com>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Eric Dong <eric.d...@intel.com>
> Signed-off-by: Benjamin Doron <benjamin.doro...@gmail.com>
> ---
> .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++--
> .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf
> ormSecLib/PlatformInit.c
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf
> ormSecLib/PlatformInit.c
> index ef89e3f31018..d74b07bc062b 100644
> ---
> .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++--
> .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
>
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> index ef89e3f31018..d74b07bc062b 100644
> ---
> a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> +++
> b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> @@ -28,6 +28,12 @@ PlatformInit (
> IN VOID *EndOfRange
> )
> {
> + //
> + // Board/Silicon initialization
> + // Prepare controllers before enabling serial port
> + //
> + BoardAfterTempRamInit ();
> +
> //
> // Platform initialization
> // Enable Serial port here
> @@ -41,7 +47,5 @@ PlatformInit (
> DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));
> DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange));
>
> - BoardAfterTempRamInit ();
> -
> TestPointTempMemoryFunction (StartOfRange, EndOfRange);
> }
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
>
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> index 486c8c72616e..53f95c29bde5 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c
> @@ -28,6 +28,12 @@ PlatformInit (
> IN VOID *EndOfRange
> )
> {
> + //
> + // Board/Silicon initialization
> + // Prepare controllers before enabling serial port
> + //
> + BoardAfterTempRamInit ();
> +
> //
> // Platform initialization
> // Enable Serial port here
> @@ -41,7 +47,5 @@ PlatformInit (
> DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange));
> DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange));
>
> - BoardAfterTempRamInit ();
> -
> TestPointTempMemoryFunction (StartOfRange, EndOfRange);
> }
> --
> 2.37.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93618): https://edk2.groups.io/g/devel/message/93618
Mute This Topic: https://groups.io/mt/93506700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
